Date: Wed, 22 Aug 2018 09:03:20 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: Yuri <yuri@rawbw.com> Cc: Kurt Jaeger <pi@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r477695 - in head/graphics: . libheif Message-ID: <20180822070320.qe7szbpsba5evn3h@atuin.in.mat.cc> In-Reply-To: <b4a250d0-7fe5-5830-d1d0-d93f3736471f@rawbw.com> References: <201808210024.w7L0OIQH031059@repo.freebsd.org> <b4a250d0-7fe5-5830-d1d0-d93f3736471f@rawbw.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--vcya2vo2qhrqakqo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 21, 2018 at 10:16:09AM -0700, Yuri wrote: > On 8/20/18 5:24 PM, Kurt Jaeger wrote: > > +BROKEN_FreeBSD_10=3D encoder_fuzzer.cc:84:5: error: use of undeclared = identifier 'free' >=20 >=20 > This is most likely wrong. 'free' is available everywhere. The likely rea= son > is a missing #include <stdlib.h> somewhere. >=20 >=20 > > +LIB_DEPENDS=3D libde265.so:multimedia/libde265 > > +LIB_DEPENDS+=3D libx265.so:multimedia/x265 > > +LIB_DEPENDS+=3D libpng16.so:graphics/png >=20 >=20 > These are usually defined without repeating LIB_DEPENDS+=3D. >=20 >=20 > > +USES=3D autoreconf libtool pkgconfig shared-mime-info \ > > + shebangfix > > +USE_GITHUB=3D yes > > +GH_ACCOUNT=3D strukturag > > +GH_PROJECT=3D libheif > > + > > +GNU_CONFIGURE=3D yes > > + > > +SHEBANG_GLOB=3D *.sh > > + > > +USE_LDCONFIG=3D yes >=20 > USE_LDCONFIG should definitely be in the USExx section. GNU_CONFIGURE and= SHEBANG_GLOB should also probably be in USExx section, because this way Ma= kefile looks more compact. A section can contain blank lines, it makes it more readable. So, this is correct. --=20 Mathieu Arnold --vcya2vo2qhrqakqo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAlt9CrdfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD zkgOzQ/7B4aikCdsI3Gzgq6EHVZAGY1hhEpjQpL/UkB3XzrV5+2KOcL1J1HyKuti xX/luA32AQfZUfWDm12AUI4awl3RxF0e60lZ5JUzhrINxb03QozvHlWKniTeYkX5 fw5Z05VrmtrsLg2iFCHFwOVvQ8LQFswsYYK1L/UJPMEKxRTQYjRy/JEXcDDTijtB GuNwMY32v1FkKi4Jnz4I/ZjZFPG3KSgFfimQznCMD+fsOUHtpxUSaamEhP0FjGK2 jRVa6F7Qgai1UXRWneAGWdumvsGAumdQ+nFA40G3/4G+ghQQ/wyd/v4M/np2iM46 a0gJZHY2kwlxxVGz4AQ8mA3KtnlJQrBsFpl+DQFeeHrVNC7F8vUu9aiIUrm5JVnI nhTdfuOrUezDgasd/x49Ds2LpysGGQU03ilfLiat+LCfCGHKeH7npBtsX0Wt4rFx qmrSTJuDMtsfpEgrdoBqtbA2Ro7Z/CDqcVaQ4lKiqvRf0u8Sq+fPriSy42ZHZNo8 UBLe1h26viJ2fUJTj7PCuzn6+cXXrsqLkPkqABHHABgoE4tfpsJhPBNx8FyQe0jJ ZiLv0b8iDme4QQcdOm6q3VrobewSPG+fbnLgJ8Af9aV9QhE+f0QyZIOQnxFcnFb7 Ad9kgBrUNNoH1y8YxanvTT/rfxpY3V12J3mXu2fchgr+jc/R7EY= =274O -----END PGP SIGNATURE----- --vcya2vo2qhrqakqo--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180822070320.qe7szbpsba5evn3h>