From owner-freebsd-current@FreeBSD.ORG  Wed Mar  3 00:09:59 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 3B76116A4CE; Wed,  3 Mar 2004 00:09:59 -0800 (PST)
Received: from exchhz01.viatech.com.cn (ip-40-162-97-218.anlai.com
	[218.97.162.40])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id A959043D1F; Wed,  3 Mar 2004 00:09:56 -0800 (PST)
	(envelope-from davidxu@freebsd.org)
Received: from freebsd.org (DAVIDWNT [10.4.1.99]) by exchhz01.viatech.com.cn
	with SMTP (Microsoft Exchange Internet Mail Service Version 5.5.2650.21)
	id FH4K6XPB; Wed, 3 Mar 2004 16:09:50 +0800
Message-ID: <404592F5.1060206@freebsd.org>
Date: Wed, 03 Mar 2004 16:10:29 +0800
From: David Xu <davidxu@freebsd.org>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US;
	rv:1.5b) Gecko/20030723 Thunderbird/0.1
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Alfred Perlstein <alfred@freebsd.org>
References: <20040303061144.GE56622@elvis.mu.org>
In-Reply-To: <20040303061144.GE56622@elvis.mu.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
cc: current@freebsd.org
Subject: Re: fix for libpthread
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Mar 2004 08:09:59 -0000

Alfred Perlstein wrote:

>This assertion doesn't seem necessary.  Apply to 
>src/lib/libpthread/thread/thr_spinlock.c
>
>
>cvs server: Diffing .
>Index: thr_spinlock.c
>===================================================================
>RCS file: /home/ncvs/src/lib/libpthread/thread/thr_spinlock.c,v
>retrieving revision 1.21
>diff -u -r1.21 thr_spinlock.c
>--- thr_spinlock.c	9 Dec 2003 02:37:40 -0000	1.21
>+++ thr_spinlock.c	3 Mar 2004 06:10:25 -0000
>@@ -79,8 +79,6 @@
> {
> 	struct spinlock_extra *extra;
> 
>-	if (!__isthreaded)
>-		PANIC("Spinlock called when not threaded.");
> 	if (!initialized)
> 		PANIC("Spinlocks not initialized.");
> 	/*
>  
>
As I saw some reports in the -CURRENT list,  the panic is always 
triggered by mix up
of libc_r and libpthread in same program. So to avoid other mysterious 
crashes,
I'd like keep the code there, it is now used to check the problem.

David Xu