From owner-freebsd-audit Mon Jul 15 4:12:30 2002 Delivered-To: freebsd-audit@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EB73237B400; Mon, 15 Jul 2002 04:12:28 -0700 (PDT) Received: from flood.ping.uio.no (flood.ping.uio.no [129.240.78.31]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6E04B43E64; Mon, 15 Jul 2002 04:12:28 -0700 (PDT) (envelope-from des@ofug.org) Received: by flood.ping.uio.no (Postfix, from userid 2602) id 73B9C534A; Mon, 15 Jul 2002 13:12:27 +0200 (CEST) X-URL: http://www.ofug.org/~des/ X-Disclaimer: The views expressed in this message do not necessarily coincide with those of any organisation or company with which I am or have been affiliated. To: Bruce Evans Cc: Giorgos Keramidas , Subject: Re: bin/ln & WARNS=5 References: <20020715202126.S40071-100000@gamplex.bde.org> From: Dag-Erling Smorgrav Date: 15 Jul 2002 13:12:26 +0200 In-Reply-To: <20020715202126.S40071-100000@gamplex.bde.org> Message-ID: Lines: 11 User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/21.2 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Bruce Evans writes: > That would break the possibly-intentional check for snprintf() failing. > (size_t)-1 >= sizeof(path), but !(-1 >= (int)sizeof(path)). Casting a value which one knows may be negative to an unsigned type is IMHO stupid. If the check is intentional, it should be done explicitly. DES -- Dag-Erling Smorgrav - des@ofug.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message