From owner-cvs-src@FreeBSD.ORG Fri Aug 29 04:39:51 2008 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DF59D1065677; Fri, 29 Aug 2008 04:39:51 +0000 (UTC) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id CCDB28FC20; Fri, 29 Aug 2008 04:39:51 +0000 (UTC) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.2/8.14.2) with ESMTP id m7T4dpF2044294; Fri, 29 Aug 2008 04:39:51 GMT (envelope-from scottl@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.2/8.14.1/Submit) id m7T4dpg2044293; Fri, 29 Aug 2008 04:39:51 GMT (envelope-from scottl@repoman.freebsd.org) Message-Id: <200808290439.m7T4dpg2044293@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to scottl@repoman.freebsd.org using -f From: Scott Long Date: Fri, 29 Aug 2008 04:39:46 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/cam/scsi scsi_da.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Aug 2008 04:39:52 -0000 scottl 2008-08-29 04:39:46 UTC FreeBSD src repository Modified files: sys/cam/scsi scsi_da.c Log: SVN rev 182433 on 2008-08-29 04:39:46Z by scottl Fix a locking mistake in daopen(). If the open fails, which can happen because the media was removed, the periph would get its refcount dropped and ultimately freed before getting unlocked. This created a dangling pointer that was easy to trip over. This fixes a common source of crashes with removaable media, but problems remain and will get tracked down. Revision Changes Path 1.228 +7 -6 src/sys/cam/scsi/scsi_da.c