From owner-freebsd-fs@FreeBSD.ORG Mon Jan 22 15:39:55 2007 Return-Path: X-Original-To: fs@freebsd.org Delivered-To: freebsd-fs@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 13B3216A404 for ; Mon, 22 Jan 2007 15:39:55 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from relay01.kiev.sovam.com (relay01.kiev.sovam.com [62.64.120.200]) by mx1.freebsd.org (Postfix) with ESMTP id AE9E713C471 for ; Mon, 22 Jan 2007 15:39:54 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from [212.82.216.227] (helo=fw.zoral.com.ua) by relay01.kiev.sovam.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.60) (envelope-from ) id 1H90bt-0002Mp-G3 for fs@freebsd.org; Mon, 22 Jan 2007 16:57:34 +0200 Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by fw.zoral.com.ua (8.13.4/8.13.4) with ESMTP id l0MEvICJ064312 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 22 Jan 2007 16:57:18 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.13.8/8.13.8) with ESMTP id l0MEvIo4035291; Mon, 22 Jan 2007 16:57:18 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.13.8/8.13.8/Submit) id l0MEvI4q035290; Mon, 22 Jan 2007 16:57:18 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Mon, 22 Jan 2007 16:57:18 +0200 From: Kostik Belousov To: Rene Ladan Message-ID: <20070122145718.GC71333@deviant.kiev.zoral.com.ua> References: <45B4C71B.1030408@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="/e2eDi0V/xtL+Mc8" Content-Disposition: inline In-Reply-To: <45B4C71B.1030408@gmail.com> User-Agent: Mutt/1.4.2.2i X-Virus-Scanned: ClamAV version 0.88.7, clamav-milter version 0.88.7 on fw.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-0.1 required=5.0 tests=ALL_TRUSTED,SPF_NEUTRAL autolearn=failed version=3.1.7 X-Spam-Checker-Version: SpamAssassin 3.1.7 (2006-10-05) on fw.zoral.com.ua X-Scanner-Signature: d3dfc5a0b247ea81d48b6a940fe6235f X-DrWeb-checked: yes X-SpamTest-Envelope-From: kostikbel@gmail.com X-SpamTest-Group-ID: 00000000 X-SpamTest-Info: Profiles 701 [Jan 22 2007] X-SpamTest-Info: helo_type=3 X-SpamTest-Info: {received from trusted relay: not dialup} X-SpamTest-Method: none X-SpamTest-Method: Local Lists X-SpamTest-Rate: 0 X-SpamTest-Status: Not detected X-SpamTest-Status-Extended: not_detected X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0255], KAS30/Release Cc: fs@freebsd.org Subject: Re: unused code in msdosfs_lookup.c ? X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jan 2007 15:39:55 -0000 --/e2eDi0V/xtL+Mc8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 22, 2007 at 03:15:55PM +0100, Rene Ladan wrote: > Hi, >=20 > while working on the XTAF fs module (see the archives), I discovered > that the code path in the lookup() routine which deals with > cnp->cn_nameptr being "." or ".." is never used. >=20 > To verify this, I added a printf() to the analogous code in > sys/fs/msdosfs/msdosfs_lookup.c (lines 134-145, revision 1.47), but the > following commands could not trigger the code: >=20 > % ls . > % ls .. > % file . > % file ../. > % hd . > % hd .. > % cd .. > % cd ../a/b > % ls -laoT . > % du /mountpoint >=20 > This code fakes the "." and ".." entries in the root directory of msdos > filesystems, which are otherwise absent. >=20 > So it seems like that code was either never tested or something in the > calling code changed (which would be cachedlookup() in VOP layer). >=20 > Ideas? See, for instance, kern/92785. --/e2eDi0V/xtL+Mc8 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFFtNDNC3+MBN1Mb4gRApCbAKC4adIYJSoAf3c+WNZXy6Nvns/wFQCfbbja RVBG/BIWGprZS3wOBgH8IyE= =U64V -----END PGP SIGNATURE----- --/e2eDi0V/xtL+Mc8--