From owner-cvs-all Fri Jul 26 9:50:26 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1AE3A37B400; Fri, 26 Jul 2002 09:50:19 -0700 (PDT) Received: from magic.adaptec.com (magic.adaptec.com [208.236.45.80]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8081B43E42; Fri, 26 Jul 2002 09:50:18 -0700 (PDT) (envelope-from scottl@btc.adaptec.com) Received: from redfish.adaptec.com (redfish.adaptec.com [162.62.50.11]) by magic.adaptec.com (8.10.2+Sun/8.10.2) with ESMTP id g6QGoHG14112; Fri, 26 Jul 2002 09:50:17 -0700 (PDT) Received: from btc.btc.adaptec.com (btc.btc.adaptec.com [10.100.0.52]) by redfish.adaptec.com (8.8.8+Sun/8.8.8) with ESMTP id JAA27947; Fri, 26 Jul 2002 09:50:17 -0700 (PDT) Received: from hollin.btc.adaptec.com (hollin [10.100.253.56]) by btc.btc.adaptec.com (8.8.8+Sun/8.8.8) with ESMTP id KAA02391; Fri, 26 Jul 2002 10:50:14 -0600 (MDT) Received: from hollin.btc.adaptec.com (localhost [127.0.0.1]) by hollin.btc.adaptec.com (8.12.5/8.12.5) with ESMTP id g6QGlHjF074663; Fri, 26 Jul 2002 10:47:17 -0600 (MDT) (envelope-from scottl@hollin.btc.adaptec.com) Received: (from scottl@localhost) by hollin.btc.adaptec.com (8.12.5/8.12.5/Submit) id g6QGlGhn074662; Fri, 26 Jul 2002 10:47:16 -0600 (MDT) Date: Fri, 26 Jul 2002 10:47:16 -0600 From: Scott Long To: "Brian F. Feldman" Cc: Josef Karthauser , cvs-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/sound/pcm mixer.c sndstat.c sound.c Message-ID: <20020726164716.GA74649@hollin.btc.adaptec.com> References: <20020726161514.GC40513@genius.tao.org.uk> <200207261643.g6QGhGJ66380@green.bikeshed.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200207261643.g6QGhGJ66380@green.bikeshed.org> User-Agent: Mutt/1.3.28i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Fri, Jul 26, 2002 at 12:43:16PM -0400, Brian F. Feldman wrote: > Josef Karthauser wrote: > > On Wed, Jul 24, 2002 at 09:49:46PM -0700, Brian Feldman wrote: > > > green 2002/07/24 21:49:45 PDT > > > > > > Modified files: > > > sys/dev/sound/pcm mixer.c sndstat.c sound.c > > > Log: > > > Fix some of the places where sound(4) can sleep with a lock held. (Help > > > courtesy of fenner). > > > > > > > And the crowd goes wild - or at least can boot unattended again :). > > You know,I don't think this code in general really WANTS to use mutexes! > The locks it's using are over entire huge code segments, and it would be > quite a bit of work to converting it to only locking structures. I don't > know that using sx locks alone would solve the possibility of deadlock that > exists now in the initialization routine paths... > Yes, it seems that the mutexes are used to protect code paths rather than data structures. It all needs a big re-write. Andrew Reiter (sp?) recently commented on this too and implied that he'd like to fix it. Andrew? To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message