From owner-cvs-usrsbin  Mon Mar 31 05:37:57 1997
Return-Path: <owner-cvs-usrsbin>
Received: (from root@localhost)
          by freefall.freebsd.org (8.8.5/8.8.5) id FAA17838
          for cvs-usrsbin-outgoing; Mon, 31 Mar 1997 05:37:57 -0800 (PST)
Received: from awfulhak.demon.co.uk (awfulhak.demon.co.uk [158.152.17.1])
          by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id FAA17810;
          Mon, 31 Mar 1997 05:37:34 -0800 (PST)
Received: from awfulhak.demon.co.uk (localhost.lan.awfulhak.org [127.0.0.1])
	by awfulhak.demon.co.uk (8.8.5/8.8.5) with ESMTP id OAA02346;
	Mon, 31 Mar 1997 14:37:00 +0100 (BST)
Message-Id: <199703311337.OAA02346@awfulhak.demon.co.uk>
X-Mailer: exmh version 1.6.9 8/22/96
To: =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= <ache@nagual.ru>
cc: Brian Somers <brian@freefall.freebsd.org>,
        CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org,
        cvs-lib@freefall.freebsd.org, cvs-usrbin@freefall.freebsd.org,
        cvs-sbin@freefall.freebsd.org, cvs-usrsbin@freefall.freebsd.org
Subject: Re: cvs commit: src/sbin/slattach Makefile src/usr.bin/tip/tip 
 Makefile src/usr.sbin/ppp Makefile src/lib/libutil uucplock.3 uucplock.c 
 Makefile libutil.h src/sbin/startslip Makefile uucplock.c
In-reply-to: Your message of "Mon, 31 Mar 1997 01:18:09 +0400."
             <Pine.BSF.3.96.970331011017.342A-100000@nagual.ru> 
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Mon, 31 Mar 1997 14:36:59 +0100
From: Brian Somers <brian@awfulhak.org>
Sender: owner-cvs-usrsbin@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

> On Sun, 30 Mar 1997, Brian Somers wrote:
> 
> >   Added:       lib/libutil  uucplock.3 uucplock.c
> >   Removed:     sbin/startslip  uucplock.c
> >   Log:
> >   Move uucplock into libutil and create a manual page.
> 
> What you do with USE_PERROR define which switch uucplock
> error loging from perror to syslog? Startslip uses syslog
> and ppp not use it. It seems that you just broke ppp since
> you left USE_PERROR define in its Makefile which unused
> now. Moreover, having library function with syslog report
> is bad idea in any case.
> 
> To fix it properly you need to change return from uucplock functions
> from int to char *, i.e. return NULL for no errors or static error
> string if error happens. Then you need to change upper level programs
> to pass this error string to perror/syslog/whatever.
> 
> -- 
> Andrey A. Chernov
> <ache@null.net>
> http://www.nagual.ru/~ache/

Oops, thanks.  I'll do the char* thing.
-- 
Brian <brian@awfulhak.org>, <brian@freebsd.org>
      <http://www.awfulhak.demon.co.uk/>
Don't _EVER_ lose your sense of humour....