From owner-svn-src-all@freebsd.org Wed Feb 20 23:35:09 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4233B14E1255 for ; Wed, 20 Feb 2019 23:35:09 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x844.google.com (mail-qt1-x844.google.com [IPv6:2607:f8b0:4864:20::844]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CFB507516C for ; Wed, 20 Feb 2019 23:35:08 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x844.google.com with SMTP id z25so7700008qti.13 for ; Wed, 20 Feb 2019 15:35:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=U2Ko2kKTv+d4rgRB5W4bXMJaSPGErsp6WZ/bCvlDPVw=; b=Quhd2FQUOUfqMsn3Rc4ckU2wZw1Py6C9Y3pTEm3j9WQ+m6bx/UvHloT5OyTMqzq9Y8 xqAgW7wFfc5equWMtz2jNfq/qrXJHB58GZkZnulchR/s0S1mU5fKm54faVOYJB0rK92i DAve7a78EAzXs9pq2P7dcTwsgchzN/0U42SMhmfyrdcSO1THwY2A5H//flFI8k6z80+T lald1xhd4pilz9NGkbO1Co80QefrS5n7ufTXLSgjBbcb04FmKo2KhRvpBin2W/PMAN1N bL4m7ThXQe2f760KmX01ZmZ57IBt1Tsl3X/ZB4vDTKp/zz/4ddICiTYL70XjZgQ4u/i8 UtGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=U2Ko2kKTv+d4rgRB5W4bXMJaSPGErsp6WZ/bCvlDPVw=; b=FIVYeFxin1sm5TbEOKqXlWcYmcfJoXceZ49uQeUqqRMnrkQRjr4vWq7QdTJST9eNED WwPwYwUQBE1MfGUkHUbr44PWQXZmV0I2+Rb3OmSNXNxbKDdmrSQb4QvW1FDyZBGUjr+H 1SjxTkiqQAuHPPi6QuAphv6L+yjoAxoDFFJkCYLzdkCqmye60F+Gxke9tqg4ZdxnzWhw gFvkVPiSn02oy/fgIjws2X+pZWw4CR0r7qpB+oCBnuUoIa3cjWdyXeA4HvwYtnkrU56U mW9TH/+UBpbl5I9cWv8NyLgMSIhUdnNhrP4bGvNBo1ZQiTgwqAIXPgPs092ynSNiuvwe Pk8g== X-Gm-Message-State: AHQUAuaBhaN7H403h2mbSRa5JB6RDDCdjJ2t42FRSheavzZcvT3Aqa/k m87TDEUuOtUcQ7tRfilgOyzs14WN1K6pCvVYn3p+XA== X-Google-Smtp-Source: AHgI3IZNFRO7+/Tgss4x8yFm1Hc+9xuT3LSs3rPTr//o2t3HLMzLVHfIuww5aYP2hzYbClb1vTuP6E6dP5R5hKvV3MU= X-Received: by 2002:ac8:35f8:: with SMTP id l53mr29997235qtb.15.1550705708231; Wed, 20 Feb 2019 15:35:08 -0800 (PST) MIME-Version: 1.0 References: <201902201705.x1KH5E9V039924@repo.freebsd.org> <201902201719.x1KHJNwL016175@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <201902201719.x1KHJNwL016175@pdx.rh.CN85.dnsmgr.net> From: Warner Losh Date: Wed, 20 Feb 2019 16:34:57 -0700 Message-ID: Subject: Re: svn commit: r344364 - vendor/illumos/dist/lib/libdtrace/common To: "Rodney W. Grimes" Cc: Mark Johnston , src-committers , svn-src-all@freebsd.org, svn-src-vendor@freebsd.org, patrick.mooney@joyent.com X-Rspamd-Queue-Id: CFB507516C X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.99)[-0.990,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Feb 2019 23:35:09 -0000 On Wed, Feb 20, 2019 at 10:19 AM Rodney W. Grimes < freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > Author: markj > > Date: Wed Feb 20 17:05:13 2019 > > New Revision: 344364 > > URL: https://svnweb.freebsd.org/changeset/base/344364 > > > > Log: > > 9058 postmortem DTrace frequently broken under vmware > > > > illumos/illumos-gate@793bd7e3617ae7d3d24e8c6b7d6befe35f07ec1f > > > > Reviewed by: Tim Kordas > > Reviewed by: Patrick Mooney > > Reviewed by: Yuri Pankov > > Reviewed by: Matthew Ahrens > > Approved by: Matthew Ahrens > > Author: Sam Gwydir > > > > Modified: > > vendor/illumos/dist/lib/libdtrace/common/dt_consume.c > > > > Modified: vendor/illumos/dist/lib/libdtrace/common/dt_consume.c > > > ============================================================================== > > --- vendor/illumos/dist/lib/libdtrace/common/dt_consume.c Wed Feb 20 > 14:12:25 2019 (r344363) > > +++ vendor/illumos/dist/lib/libdtrace/common/dt_consume.c Wed Feb 20 > 17:05:13 2019 (r344364) > > @@ -24,7 +24,7 @@ > > */ > > > > /* > > - * Copyright (c) 2013, Joyent, Inc. All rights reserved. > > + * Copyright (c) 2017, Joyent, Inc. All rights reserved. > > This change to this copyright is very questionable. > One should always retain the first date of publication > in a copyright statement. > > I do understand your just importing a change from illumous, > but I want it on public record that I have raised issue > with this change to a copyright, and this has nothing to > do with you personally, or you wanting to bring this code > over. > Joyent is following the old Sun practice of listing the last date only. I've had my company's lawyers tell me in the past this is acceptable. In my research, as layperson, I've found advice going all three ways: list every year, or else; earliest-latest year range; only the latest year. I once asked an IP lawyer that handled a friend's trademark case for clue.com. He said that there is a diversity of legal opinion in the legal community, and that in some specific cases one might be favored over the other. Most of the time, in his opinion, the differences don't matter to open source. He hastened to add he couldn't give any blanket statements on the topic and for proper legal advice he'd need to know more about the specific use. And then we had another beer and chatted about other things. I never followed up. In the years since this, I've seen all three styles used. Warner > * Copyright (c) 2012 by Delphix. All rights reserved. > > */ > > > > @@ -3010,9 +3010,6 @@ dtrace_consume(dtrace_hdl_t *dtp, FILE *fp, > > break; > > > > timestamp = dt_buf_oldest(buf, dtp); > > - assert(timestamp >= dtp->dt_last_timestamp); > > - dtp->dt_last_timestamp = timestamp; > > - > > if (timestamp == buf->dtbd_timestamp) { > > /* > > * We've reached the end of the time > covered > > @@ -3026,6 +3023,8 @@ dtrace_consume(dtrace_hdl_t *dtp, FILE *fp, > > break; > > continue; > > } > > + assert(timestamp >= dtp->dt_last_timestamp); > > + dtp->dt_last_timestamp = timestamp; > > > > if ((rval = dt_consume_cpu(dtp, fp, > > buf->dtbd_cpu, buf, B_TRUE, pf, rf, arg)) != 0) > > > > > > -- > Rod Grimes > rgrimes@freebsd.org > >