From owner-svn-ports-all@freebsd.org  Sun Feb 19 16:06:50 2017
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 15316CE5B54;
 Sun, 19 Feb 2017 16:06:50 +0000 (UTC)
 (envelope-from gerald@pfeifer.com)
Received: from ainaz.pair.com (ainaz.pair.com [209.68.2.66])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id EB49818E0;
 Sun, 19 Feb 2017 16:06:49 +0000 (UTC)
 (envelope-from gerald@pfeifer.com)
Received: from anthias (vie-188-118-248-079.dsl.sil.at [188.118.248.79])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ainaz.pair.com (Postfix) with ESMTPSA id 724493F530;
 Sun, 19 Feb 2017 11:06:47 -0500 (EST)
Date: Sun, 19 Feb 2017 17:06:45 +0100 (CET)
From: Gerald Pfeifer <gerald@pfeifer.com>
To: Alexey Dokuchaev <danfe@FreeBSD.org>
cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, 
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r402352 - head/lang/gcc
In-Reply-To: <20151124110152.GA78748@FreeBSD.org>
Message-ID: <alpine.LSU.2.20.1702191430520.2410@anthias.pfeifer.com>
References: <201511241019.tAOAJMTF049917@repo.freebsd.org>
 <20151124110152.GA78748@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 19 Feb 2017 16:06:50 -0000

[ Old e-mail alert -- but still relevant ]

On Tue, 24 Nov 2015, Alexey Dokuchaev wrote:
>> +	for c in gfortran g++ gcc; do \
>> +	    ${LN} -s ${PREFIX}/bin/"$$c"${SUFFIX} ${STAGEDIR}${PREFIX}/bin/$$c ; \
>> +	done
> Symlinks are badly created (will be broken if e.g. $prefix mounted under
> non-/ via NFS), better (untested) approach would be:
> 
> .for f in gfortran g++ gcc
> 	${LN} -sf ${f}${SUFFIX} ${STAGEDIR}${PREFIX}/bin/${f}
> .endfor

At first I wasn't completely clear what you had in mind here (or 
rather: why exactly), and I did not get a single report from a 
user in the 15 months since then.

On the other hand, we can always improve things and what I understand
you aimed for seems more consistent with how we generally do things.


What do you think about the patch below?

Only problem is, portlint now warns

  WARN: g++: this is a symlink. Please remove it.
  WARN: gcc: this is a symlink. Please remove it.
  WARN: gfortran: this is a symlink. Please remove it.

which I did not do when I've been using absolute paths.

Gerald

Index: Makefile
===================================================================
--- Makefile	(revision 434403)
+++ Makefile	(working copy)
@@ -164,7 +167,7 @@
 	# This is the canonical GCC port, so add key commands without
 	# version numbers as part of their names.
 	for c in gfortran g++ gcc; do \
-	    ${LN} -s ${PREFIX}/bin/"$$c"${SUFFIX} ${STAGEDIR}${PREFIX}/bin/$$c ; \
+	    ${LN} -s $${c}${SUFFIX} ${STAGEDIR}${PREFIX}/bin/$${c} ; \
 	done
 
 .include <bsd.port.post.mk>