From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Nov 5 10:30:10 2010 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B15BA1065670 for ; Fri, 5 Nov 2010 10:30:10 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 6D1688FC15 for ; Fri, 5 Nov 2010 10:30:10 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id oA5AUAFW064836 for ; Fri, 5 Nov 2010 10:30:10 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id oA5AUAXi064834; Fri, 5 Nov 2010 10:30:10 GMT (envelope-from gnats) Resent-Date: Fri, 5 Nov 2010 10:30:10 GMT Resent-Message-Id: <201011051030.oA5AUAXi064834@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, KOMATSU Shinichiro Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B3D8E106564A for ; Fri, 5 Nov 2010 10:21:10 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id A10D48FC15 for ; Fri, 5 Nov 2010 10:21:10 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id oA5ALA2c014453 for ; Fri, 5 Nov 2010 10:21:10 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id oA5ALA8w014452; Fri, 5 Nov 2010 10:21:10 GMT (envelope-from nobody) Message-Id: <201011051021.oA5ALA8w014452@www.freebsd.org> Date: Fri, 5 Nov 2010 10:21:10 GMT From: KOMATSU Shinichiro To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/151960: archivers/unzip: Fix build when both WITH_UNZIP_UNREDUCE and WITH_ICONV are set. X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2010 10:30:10 -0000 >Number: 151960 >Category: ports >Synopsis: archivers/unzip: Fix build when both WITH_UNZIP_UNREDUCE and WITH_ICONV are set. >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Nov 05 10:30:10 UTC 2010 >Closed-Date: >Last-Modified: >Originator: KOMATSU Shinichiro >Release: FreeBSD 7.3-RELEASE-p2 amd64 >Organization: >Environment: FreeBSD 7.3-RELEASE-p2 amd64 >Description: When archivers/unzip is built with both WITH_UNZIP_UNREDUCE and WITH_ICONV are set, it fails with the following error. cc -c -O2 -fno-strict-aliasing -pipe -I. -Ibzip2 -DUNIX unix/unix.c unix/unix.c:33:19: error: iconv.h: No such file or directory unix/unix.c: In function 'charset_to_intern': unix/unix.c:1926: error: 'iconv_t' undeclared (first use in this function) unix/unix.c:1926: error: (Each undeclared identifier is reported only once unix/unix.c:1926: error: for each function it appears in.) unix/unix.c:1926: error: expected ';' before 'cd' unix/unix.c:1937: error: 'cd' undeclared (first use in this function) *** Error code 1 To fix this, CFLAGS is passed to make at pre-build stage. >How-To-Repeat: >Fix: Patch attached with submission follows: Index: Makefile =================================================================== RCS file: /home/ncvs/ports/archivers/unzip/Makefile,v retrieving revision 1.68 diff -u -r1.68 Makefile --- Makefile 20 Sep 2010 06:14:24 -0000 1.68 +++ Makefile 4 Nov 2010 11:40:55 -0000 @@ -43,7 +43,7 @@ PATCH_DIST_STRIP= -p1 USE_ICONV= yes CFLAGS+= -I${LOCALBASE}/include -DNATIVE -MAKE_ARGS+= LFLAGS1="-L${LOCALBASE}/lib -liconv" +MAKE_ARGS+= LFLAGS1="-L${LOCALBASE}/lib -liconv" CFLAGS="${CFLAGS}" .endif MAKE_ENV= LOCAL_UNZIP="${LOCAL_UNZIP}" \ >Release-Note: >Audit-Trail: >Unformatted: