From owner-freebsd-firewire@FreeBSD.ORG  Mon May 26 23:25:54 2003
Return-Path: <owner-freebsd-firewire@FreeBSD.ORG>
Delivered-To: freebsd-firewire@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id EC36F37B401
	for <freebsd-firewire@freebsd.org>;
	Mon, 26 May 2003 23:25:54 -0700 (PDT)
Received: from is2.mh.itc.u-tokyo.ac.jp (is2.mh.itc.u-tokyo.ac.jp
	[133.11.205.12])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5F05E43FA3
	for <freebsd-firewire@freebsd.org>;
	Mon, 26 May 2003 23:25:53 -0700 (PDT)
	(envelope-from simokawa@sat.t.u-tokyo.ac.jp)
Received: from is2.mh.itc.u-tokyo.ac.jp (is2.mh.itc.u-tokyo.ac.jp [127.0.0.1])
	by is2.mh.itc.u-tokyo.ac.jp (Postfix) with ESMTP id 71578378074
	for <freebsd-firewire@freebsd.org>;
	Tue, 27 May 2003 15:25:51 +0900 (JST)
Received: from mailhosting.itc.u-tokyo.ac.jp
	(IDENT:mirapoint@mailhosting.itc.u-tokyo.ac.jp [133.11.205.3])
	h4R6PpjL008891;	Tue, 27 May 2003 15:25:51 +0900
Received: from ett.sat.t.u-tokyo.ac.jp (ett.sat.t.u-tokyo.ac.jp
	[133.11.135.3])3.3.5-GR)	with ESMTP id AIT81139;
	Tue, 27 May 2003 15:25:50 +0900 (JST)
Date: Tue, 27 May 2003 15:25:50 +0900
Message-ID: <ybsptm4ykgh.wl@ett.sat.t.u-tokyo.ac.jp>
From: Hidetoshi Shimokawa <simokawa@sat.t.u-tokyo.ac.jp>
To: Chuck McCrobie <mccrobie2000@yahoo.com>
In-Reply-To: <20030512170820.41494.qmail@web14811.mail.yahoo.com>
References: <20030512170820.41494.qmail@web14811.mail.yahoo.com>
User-Agent: Wanderlust/2.11.0 (Wonderwall) REMI/1.14.3 (Matsudai)
 FLIM/1.14.3 (=?ISO-8859-1?Q?Unebigory=F2mae?=) APEL/10.3 MULE XEmacs/21.4
 (patch 8) (Honest Recruiter) (i386--freebsd)
X-Face: OE([KxWyJI0r[R~S/>7ia}SJ)i%a,$-9%7{*yihQk|]gl}2p#"oXmX/fT}Bn7:
 #j7i14gu$jgR\S*&C3R/pJX<mI-4Z8'mqt1R'CjWdw-xqVoilv`\JgZcquM5oV
 uO^<vt/~051rCDM(`{rM~?{Okr,XC+}Ycm9IJO)odT*-0nyJjBJYzL{GsZ
MIME-Version: 1.0 (generated by REMI 1.14.3 - "Matsudai")
Content-Type: text/plain; charset=US-ASCII
cc: freebsd-firewire@freebsd.org
Subject: Re: Errors during probe cause inifinite loop in sbp
X-BeenThere: freebsd-firewire@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Vendors pre-release coordination <freebsd-firewire.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-firewire>,
	<mailto:freebsd-firewire-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-firewire>
List-Post: <mailto:freebsd-firewire@freebsd.org>
List-Help: <mailto:freebsd-firewire-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-firewire>,
	<mailto:freebsd-firewire-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 27 May 2003 06:25:55 -0000

At Mon, 12 May 2003 10:08:20 -0700 (PDT),
Chuck McCrobie wrote:
> 
> [1  <text/plain; us-ascii (7bit)>]
> Please find attached the log file from a boot with the
> PowerFile changer.  One drive in the changer does not
> support the "12 21 80 00 ff 00" command that is sent
> during XPT probing.
> 
> When the error comes back, it appears sbp endlessly
> resends the command.
> 
> Attached /var/log/message output.
> 
> I managed to get the changer working by adding a
> CAM_QUIRK_NOSERIAL to the cam_xpt.c file, but this
> seems to be quite a hack.
> 
> I can try debugging code, etc. since I still have
> access to the PowerFile.

Can you try this patch?

Index: sbp.c
===================================================================
RCS file: /pub/FreeBSD-CVS/src/sys/dev/firewire/sbp.c,v
retrieving revision 1.51
diff -u -r1.51 sbp.c
--- sbp.c	12 May 2003 00:42:28 -0000	1.51
+++ sbp.c	27 May 2003 06:21:54 -0000
@@ -1090,7 +1090,7 @@
 	xfer = sbp_write_cmd(sdev, FWTCODE_WREQQ, 0x04);
 	if (xfer == NULL)
 		return;
-	if (sdev->status == SBP_DEV_ATTACHED)
+	if (sdev->status == SBP_DEV_ATTACHED || sdev->status == SBP_DEV_PROBE)
 		xfer->act.hand = sbp_agent_reset_callback;
 	else
 		xfer->act.hand = sbp_do_attach;

/\ Hidetoshi Shimokawa
\/  simokawa@sat.t.u-tokyo.ac.jp
PGP public key: http://www.sat.t.u-tokyo.ac.jp/~simokawa/pgp.html