Date: Tue, 27 May 2003 15:25:50 +0900 From: Hidetoshi Shimokawa <simokawa@sat.t.u-tokyo.ac.jp> To: Chuck McCrobie <mccrobie2000@yahoo.com> Cc: freebsd-firewire@freebsd.org Subject: Re: Errors during probe cause inifinite loop in sbp Message-ID: <ybsptm4ykgh.wl@ett.sat.t.u-tokyo.ac.jp> In-Reply-To: <20030512170820.41494.qmail@web14811.mail.yahoo.com> References: <20030512170820.41494.qmail@web14811.mail.yahoo.com>
next in thread | previous in thread | raw e-mail | index | archive | help
At Mon, 12 May 2003 10:08:20 -0700 (PDT), Chuck McCrobie wrote: > > [1 <text/plain; us-ascii (7bit)>] > Please find attached the log file from a boot with the > PowerFile changer. One drive in the changer does not > support the "12 21 80 00 ff 00" command that is sent > during XPT probing. > > When the error comes back, it appears sbp endlessly > resends the command. > > Attached /var/log/message output. > > I managed to get the changer working by adding a > CAM_QUIRK_NOSERIAL to the cam_xpt.c file, but this > seems to be quite a hack. > > I can try debugging code, etc. since I still have > access to the PowerFile. Can you try this patch? Index: sbp.c =================================================================== RCS file: /pub/FreeBSD-CVS/src/sys/dev/firewire/sbp.c,v retrieving revision 1.51 diff -u -r1.51 sbp.c --- sbp.c 12 May 2003 00:42:28 -0000 1.51 +++ sbp.c 27 May 2003 06:21:54 -0000 @@ -1090,7 +1090,7 @@ xfer = sbp_write_cmd(sdev, FWTCODE_WREQQ, 0x04); if (xfer == NULL) return; - if (sdev->status == SBP_DEV_ATTACHED) + if (sdev->status == SBP_DEV_ATTACHED || sdev->status == SBP_DEV_PROBE) xfer->act.hand = sbp_agent_reset_callback; else xfer->act.hand = sbp_do_attach; /\ Hidetoshi Shimokawa \/ simokawa@sat.t.u-tokyo.ac.jp PGP public key: http://www.sat.t.u-tokyo.ac.jp/~simokawa/pgp.html
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ybsptm4ykgh.wl>