From owner-freebsd-current Fri Jan 17 15:28:34 2003 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1F53237B401 for ; Fri, 17 Jan 2003 15:28:32 -0800 (PST) Received: from h00609772adf0.ne.client2.attbi.com (h00609772adf0.ne.client2.attbi.com [24.61.43.152]) by mx1.FreeBSD.org (Postfix) with ESMTP id 569D143F1E for ; Fri, 17 Jan 2003 15:28:31 -0800 (PST) (envelope-from rodrigc@attbi.com) Received: from h00609772adf0.ne.client2.attbi.com (localhost [127.0.0.1]) by h00609772adf0.ne.client2.attbi.com (8.12.6/8.12.6) with ESMTP id h0HNSSTc005342; Fri, 17 Jan 2003 18:28:28 -0500 (EST) (envelope-from rodrigc@h00609772adf0.ne.client2.attbi.com) Received: (from rodrigc@localhost) by h00609772adf0.ne.client2.attbi.com (8.12.6/8.12.6/Submit) id h0HNSMIi005341; Fri, 17 Jan 2003 18:28:22 -0500 (EST) Date: Fri, 17 Jan 2003 18:28:21 -0500 From: Craig Rodrigues To: Will Andrews Cc: Joe Marcus Clarke , freebsd-current@FreeBSD.ORG Subject: Re: VM_METER no longer defined? Message-ID: <20030117232821.GA5237@attbi.com> References: <3E284083.3030504@btc.adaptec.com> <1042826526.328.24.camel@gyros> <20030117182610.GR30015@procyon.firepipe.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030117182610.GR30015@procyon.firepipe.net> User-Agent: Mutt/1.4i Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Fri, Jan 17, 2003 at 10:26:10AM -0800, Will Andrews wrote: > Of course, these things can be fixed. But I consider this change > gratuitous and it breaks standard compatability rules: deprecate > for one major version and remove in the second. I haven't seen > any reason why this couldn't be added to vm/vm_param.h: > > #define VM_METER VM_TOTAL > > for compatability purposes. This change is way too sudden in an > external API (if it's supposed to be internal, then protect it > with an #ifdef _KERNEL already!). How about this then: Index: vm_param.h =================================================================== RCS file: /home/ncvs/src/sys/vm/vm_param.h,v retrieving revision 1.16 diff -u -r1.16 vm_param.h --- vm_param.h 2003/01/11 07:29:46 1.16 +++ vm_param.h 2003/01/17 23:25:52 @@ -89,6 +89,8 @@ #define VM_SWAPPING_ENABLED 11 /* swapping enabled */ #define VM_MAXID 12 /* number of valid vm ids */ +#define VM_METER VM_TOTAL /* backwards compatibility, struct vmmeter */ + #define CTL_VM_NAMES { \ { 0, 0 }, \ { "vmtotal", CTLTYPE_STRUCT }, \ The only place where VM_METER is used in this directory was in vm_meter.c: 240 SYSCTL_PROC(_vm, VM_METER, vmmeter, CTLTYPE_OPAQUE|CTLFLAG_RD, 241 0, sizeof(struct vmtotal), vmtotal, "S,vmtotal", 242 "System virtual memory statistics"); This changed to: 240 SYSCTL_PROC(_vm, VM_TOTAL, vmtotal, CTLTYPE_OPAQUE|CTLFLAG_RD, 241 0, sizeof(struct vmtotal), vmtotal, "S,vmtotal", 242 "System virtual memory statistics"); -- Craig Rodrigues http://home.attbi.com/~rodrigc rodrigc@attbi.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message