From owner-cvs-all@FreeBSD.ORG  Thu Jan 18 20:11:12 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@freebsd.org
Delivered-To: cvs-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 5CF2B16A4AB;
	Thu, 18 Jan 2007 20:11:12 +0000 (UTC)
	(envelope-from mjacob@freebsd.org)
Received: from ns1.feral.com (ns1.feral.com [192.67.166.1])
	by mx1.freebsd.org (Postfix) with ESMTP id 3658813C44C;
	Thu, 18 Jan 2007 20:11:12 +0000 (UTC)
	(envelope-from mjacob@freebsd.org)
Received: from ns1.feral.com (localhost [127.0.0.1])
	by ns1.feral.com (8.13.8/8.13.8) with ESMTP id l0IJpiCR002581;
	Thu, 18 Jan 2007 11:51:52 -0800 (PST)
	(envelope-from mjacob@freebsd.org)
Received: from localhost (mjacob@localhost)
	by ns1.feral.com (8.13.8/8.13.8/Submit) with ESMTP id l0IJpiXk002578;
	Thu, 18 Jan 2007 11:51:44 -0800 (PST)
	(envelope-from mjacob@freebsd.org)
X-Authentication-Warning: ns1.feral.com: mjacob owned process doing -bs
Date: Thu, 18 Jan 2007 11:51:44 -0800 (PST)
From: mjacob@freebsd.org
To: "David O'Brien" <obrien@freebsd.org>
In-Reply-To: <20070118185616.GA67767@dragon.NUXI.org>
Message-ID: <20070118115113.U2516@ns1.feral.com>
References: <200701181355.l0IDtMFu003540@repoman.freebsd.org>
	<20070118185616.GA67767@dragon.NUXI.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: cvs-src@freebsd.org, Gleb Smirnoff <glebius@freebsd.org>,
	src-committers@freebsd.org, cvs-all@freebsd.org
Subject: Re: cvs commit: src/sys/netgraph ng_ppp.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: mjacob@freebsd.org
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Jan 2007 20:11:12 -0000

> /usr/src/sys/modules/netgraph/ppp/../../../netgraph/ng_ppp.c: In function `ng_ppp_rcvdata':
> /usr/src/sys/modules/netgraph/ppp/../../../netgraph/ng_ppp.c:1287: warning: comparison is always true due to limited range of data type
> *** Error code 1
>
> I commented out the KASSERT in order to get the kernel buildable again.
> Would you be able to take a look at the logic in the KASSERT?  I'd rather
> not guess what you'd like there and possibly get it wrong.
> thanks,

Fools rush in (me). I changed the logic.