From owner-svn-src-all@FreeBSD.ORG Wed Oct 22 01:25:17 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4174CD93; Wed, 22 Oct 2014 01:25:17 +0000 (UTC) Received: from smtp.des.no (smtp.des.no [194.63.250.102]) by mx1.freebsd.org (Postfix) with ESMTP id 01594B8F; Wed, 22 Oct 2014 01:25:16 +0000 (UTC) Received: from nine.des.no (smtp.des.no [194.63.250.102]) by smtp-int.des.no (Postfix) with ESMTP id C5BEDA5C8; Wed, 22 Oct 2014 01:25:14 +0000 (UTC) Received: by nine.des.no (Postfix, from userid 1001) id DB6FE54BC; Wed, 22 Oct 2014 03:25:02 +0200 (CEST) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Warner Losh Subject: Re: svn commit: r273417 - head References: <201410212029.s9LKThT2074337@svn.freebsd.org> Date: Wed, 22 Oct 2014 03:25:02 +0200 In-Reply-To: <201410212029.s9LKThT2074337@svn.freebsd.org> (Warner Losh's message of "Tue, 21 Oct 2014 20:29:43 +0000 (UTC)") Message-ID: <86d29k28wh.fsf@nine.des.no> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Oct 2014 01:25:17 -0000 Warner Losh writes: > Author: imp > Date: Tue Oct 21 20:29:42 2014 > New Revision: 273417 > URL: https://svnweb.freebsd.org/changeset/base/273417 > > Log: > You aren't allowed to test WITH_xxx or WITHOUT_xxx here, so remove it. > Even if you were allowed to test for it, the test makes no sense as it > always results in adding -DWITH_ATF unless WITH_ATF was already > defined. But if MK_ATF !=3D no, then we know it was defined. This, in > turn, caused tools/build/options/makemake always think WITH_ATF is the > default, which removed control of that from sys.conf.mk. >=20=20=20 > To get the intent of the deleted comment, another mechanism is > required, assuming that the intent of that comment is desirable. This broke the paralell build. It prevents building lib/atf entirely in stage 4.3, so the programs in libexec/atf have nothing to link against unless lib/atf just happens to get built before libexec/atf. That almost never happens: lib and libexec are built in paralell, and lib/atf is one of the last items in lib whereas libexec/atf is one of the first items in libexec. (on a side note, libatf doesn't need to be in _prebuild_libs, since no other library depend on it) DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no