From owner-cvs-all@FreeBSD.ORG Thu Apr 3 01:38:03 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 39A2037B401; Thu, 3 Apr 2003 01:38:03 -0800 (PST) Received: from ns1.xcllnt.net (209-128-86-226.BAYAREA.NET [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id D634F43F3F; Thu, 3 Apr 2003 01:38:01 -0800 (PST) (envelope-from marcel@xcllnt.net) Received: from dhcp01.pn.xcllnt.net (dhcp01.pn.xcllnt.net [192.168.4.201]) by ns1.xcllnt.net (8.12.8/8.12.8) with ESMTP id h339c1Ku085064; Thu, 3 Apr 2003 01:38:01 -0800 (PST) (envelope-from marcel@piii.pn.xcllnt.net) Received: from dhcp01.pn.xcllnt.net (localhost [127.0.0.1]) by dhcp01.pn.xcllnt.net (8.12.9/8.12.8) with ESMTP id h339c1TH068223; Thu, 3 Apr 2003 01:38:01 -0800 (PST) (envelope-from marcel@dhcp01.pn.xcllnt.net) Received: (from marcel@localhost) by dhcp01.pn.xcllnt.net (8.12.9/8.12.9/Submit) id h339c04g068222; Thu, 3 Apr 2003 01:38:00 -0800 (PST) Date: Thu, 3 Apr 2003 01:38:00 -0800 From: Marcel Moolenaar To: Ruslan Ermilov Message-ID: <20030403093800.GA68012@dhcp01.pn.xcllnt.net> References: <200304030513.h335DR60079544@repoman.freebsd.org> <20030402231638.A81523@FreeBSD.org> <20030403055049.GA67232@dhcp01.pn.xcllnt.net> <20030403180026.A29934@gamplex.bde.org> <20030403085350.GA37174@sunbay.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030403085350.GA37174@sunbay.com> User-Agent: Mutt/1.5.3i cc: Juli Mallett cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Bruce Evans Subject: Re: cvs commit: src/libexec/talkd announce.c extern.h print.c table.c talkd.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Apr 2003 09:38:03 -0000 On Thu, Apr 03, 2003 at 11:53:50AM +0300, Ruslan Ermilov wrote: > > > How's this bugfix? > > %%% > Index: bsd.sys.mk > =================================================================== > RCS file: /home/ncvs/src/share/mk/bsd.sys.mk,v > retrieving revision 1.12 > diff -u -r1.12 bsd.sys.mk > --- bsd.sys.mk 31 Mar 2003 13:10:51 -0000 1.12 > +++ bsd.sys.mk 3 Apr 2003 08:48:40 -0000 > @@ -25,7 +25,7 @@ > . if ${WARNS} > 3 > CFLAGS += -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wcast-align > . endif > -. if ${WARNS} > 4 > +. if ${WARNS} > 4 && !empty(CFLAGS:M-O*) && empty(CFLAGS:M-O0) > CFLAGS += -Wuninitialized > . endif > # BDECFLAGS > %%% Should work in most cases, but beware DEBUG_FLAGS. The above does not catch the case where DEBUG_FLAGS is defined to something like "-O0 -g". I think this is a reasonable use of DEBUG_FLAGS. \begin{log} dhcp01% setenv DEBUG_FLAGS "-O0 -g" dhcp01% setenv CFLAGS -O dhcp01% make cc -O -mcpu=pentiumpro -I/usr/local/src/fpi/cpu/.. -O0 -g -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wcast-align -Wuninitialized -c decode.c cc1: warnings being treated as errors cc1: warning: -Wuninitialized is not supported without -O *** Error code 1 \end{log} -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net