Date: Fri, 3 May 2002 07:30:44 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: "J. Mallett" <jmallett@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/usr.bin/xargs xargs.c Message-ID: <20020503072052.B5240-100000@gamplex.bde.org> In-Reply-To: <200205020521.g425LZF87064@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 1 May 2002, J. Mallett wrote:
> jmallett 2002/05/01 22:21:35 PDT
>
> Modified files:
> usr.bin/xargs xargs.c
> Log:
> __COPYRIGHT() and __SCCSID().
These should never be used. They create conflicts for future imports
and enlarge diffs with the vendor version by editing vendor lines,
and using __COPYRIGHT demonstrates a bug in its implementation:
%%%
Script started on Fri May 3 07:20:19 2002
ttyp0:bde@besplex:/usr/src/usr.bin/xargs> make
cc -O -pipe -Werror -Wall -W -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wcast-align -Wno-uninitialized -c /usr/src/usr.bin/xargs/xargs.c
{standard input}: Assembler messages:
{standard input}:5: Warning: unterminated string; newline inserted
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
{standard input}:6: Warning: unterminated string; newline inserted
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
cc -O -pipe -Werror -Wall -W -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wcast-align -Wno-uninitialized -c /usr/src/usr.bin/xargs/strnsubst.c
cc -O -pipe -Werror -Wall -W -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wcast-align -Wno-uninitialized -static -o xargs xargs.o strnsubst.o
gzip -cn /usr/src/usr.bin/xargs/xargs.1 > xargs.1.gz
ttyp0:bde@besplex:/usr/src/usr.bin/xargs> exit
Script done on Fri May 3 07:20:20 2002
%%%
The problem is that __COPYRIGHT() (normally) uses __asm(), and __asm()
expands \n to a hard newline, and hard newlines are syntax errors in gas.
Some vendor copyrights have been corrupted further by editing them to
remove the hard newline.
Similarly in the m4 sources. We've already had 2 rounds of editing
CSRG ids in m4: first to mess them up by wrapping them in __SCCSID()
and expand the tab in them; second to unexpand the tab. Apparently
NetBSD expands the tab but OpenBSD doesn't.
Bruce
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020503072052.B5240-100000>