From owner-dev-commits-src-all@freebsd.org Thu Jan 28 18:29:22 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3FC6B4E62C4 for ; Thu, 28 Jan 2021 18:29:22 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DRTX21CbBz4V6H for ; Thu, 28 Jan 2021 18:29:22 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: by mail-wr1-f51.google.com with SMTP id z6so6365053wrq.10 for ; Thu, 28 Jan 2021 10:29:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=w7s7kwVypItHslAc1aebknBDWy4tIV/FiTp8vAADVkk=; b=A0YTDwxhWH3EqI6j2b5EWSW/Zbre9WpQn2QOZEzwoFZWnUOBpGu4tjaLnahXNaVMK+ x0Dpx/HgxTUhuYeAV8Xxuh/QOofMmp6zZfAMkKQVw/KFI7cssfGZOag0c9P3jmc9DK6M G3Wl8ERzYqQ8C888Pu4cRh8dkcnWqQUMKtTyXLz6dJCWCe+5nBLE8qNC+pKo4t0GnlLq c6HvHrJmXGjoeVIi+CcN2Xg7RxQSwMd/OLbiw2eBZ65x8A2dle48XxSSX7M6bObZuwg+ h6cnT6cBOWZdQVkO8UInD6o77tNmwhA09SPzCCNyfyJyHLoPv5s/3+Y/rpNb5vyK5Cxd DO3Q== X-Gm-Message-State: AOAM531OlpSPBfDMC1KouPXfKU3G7A2lPsJsxRVtyDtPoU36+Mesh8Kp D0Z7ZU2pOWRFtDF7piFk7+m1Mg== X-Google-Smtp-Source: ABdhPJx17gDKLA7LdNOrqY24JmZHM5HBu+PIkKe3eZ6eTMvkwqBca3ers3/1c4AqZl/3LBeY+0jE5Q== X-Received: by 2002:adf:d0d2:: with SMTP id z18mr504249wrh.70.1611858560903; Thu, 28 Jan 2021 10:29:20 -0800 (PST) Received: from [192.168.149.251] (trinity-students-nat.trin.cam.ac.uk. [131.111.193.104]) by smtp.gmail.com with ESMTPSA id d30sm8381324wrc.92.2021.01.28.10.29.20 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Jan 2021 10:29:20 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Subject: Re: git: 83ff5d5d98cb - main - Un-XFAIL two tests with Clang > 10 From: Jessica Clarke In-Reply-To: Date: Thu, 28 Jan 2021 18:29:19 +0000 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <202101281739.10SHdh37056796@gitrepo.freebsd.org> <6B60F7D5-AD3E-459E-801A-65234A689A01@freebsd.org> To: Alexander Richardson X-Mailer: Apple Mail (2.3608.120.23.2.4) X-Rspamd-Queue-Id: 4DRTX21CbBz4V6H X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jan 2021 18:29:22 -0000 On 28 Jan 2021, at 17:46, Alexander Richardson = wrote: > On Thu, 28 Jan 2021 at 17:42, Jessica Clarke = wrote: >>=20 >> Is the commit message or the diff wrong? Both use strict = inequalities. >>=20 >> Jess >=20 > Sorry the commit message should be >=3D 10. Thanks. I see now the first XFAIL message was updated to say 7-9 (which answers my question), but the second one I was looking at was not. Could you please correct that? Jess >>=20 >> On 28 Jan 2021, at 17:39, Alex Richardson = wrote: >>>=20 >>> The branch main has been updated by arichardson: >>>=20 >>> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D83ff5d5d98cbcf9b66dccd70022358ae= c8918a14 >>>=20 >>> commit 83ff5d5d98cbcf9b66dccd70022358aec8918a14 >>> Author: Alex Richardson >>> AuthorDate: 2021-01-28 17:17:49 +0000 >>> Commit: Alex Richardson >>> CommitDate: 2021-01-28 17:24:24 +0000 >>>=20 >>> Un-XFAIL two tests with Clang > 10 >>>=20 >>> SVN r343917 fixed this for in-tree clang, but when building with a = newer >>> out-of-tree clang the test was still marked as XFAIL. >>>=20 >>> Reviewed By: dim >>> Differential Revision: https://reviews.freebsd.org/D28390 >>> --- >>> contrib/netbsd-tests/lib/libm/t_cbrt.c | 4 ++-- >>> lib/msun/tests/trig_test.c | 2 +- >>> 2 files changed, 3 insertions(+), 3 deletions(-) >>>=20 >>> diff --git a/contrib/netbsd-tests/lib/libm/t_cbrt.c = b/contrib/netbsd-tests/lib/libm/t_cbrt.c >>> index d2cdd47a5beb..08e9faeb145c 100644 >>> --- a/contrib/netbsd-tests/lib/libm/t_cbrt.c >>> +++ b/contrib/netbsd-tests/lib/libm/t_cbrt.c >>> @@ -269,8 +269,8 @@ ATF_TC_BODY(cbrtl_powl, tc) >>> size_t i; >>>=20 >>> #if defined(__amd64__) && defined(__clang__) && __clang_major__ >=3D = 7 && \ >>> - __FreeBSD_cc_version < 1300002 >>> - atf_tc_expect_fail("test fails with clang 7+ - bug 234040"); >>> + __clang_major__ < 10 && __FreeBSD_cc_version < 1300002 >>> + atf_tc_expect_fail("test fails with clang 7-9 - bug 234040"); >>> #endif >>>=20 >>> for (i =3D 0; i < __arraycount(x); i++) { >>> diff --git a/lib/msun/tests/trig_test.c b/lib/msun/tests/trig_test.c >>> index 483a5e187d50..ba1975721d3f 100644 >>> --- a/lib/msun/tests/trig_test.c >>> +++ b/lib/msun/tests/trig_test.c >>> @@ -161,7 +161,7 @@ ATF_TC_BODY(reduction, tc) >>> unsigned i; >>>=20 >>> #if defined(__amd64__) && defined(__clang__) && __clang_major__ >=3D = 7 && \ >>> - __FreeBSD_cc_version < 1300002 >>> + __clang_major__ < 10 && __FreeBSD_cc_version < 1300002 >>> atf_tc_expect_fail("test fails with clang 7+ - bug 234040"); >>> #endif >>>=20 >>=20