Date: Sat, 10 Sep 2011 13:10:24 +0200 From: Hans Petter Selasky <hselasky@c2i.net> To: Robert Watson <rwatson@freebsd.org> Cc: "svn-src-stable@freebsd.org" <svn-src-stable@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-stable-8@freebsd.org" <svn-src-stable-8@freebsd.org> Subject: Re: svn commit: r225458 - in stable/8/sys: dev/usb dev/usb/quirk dev/usb/storage sys Message-ID: <201109101310.24841.hselasky@c2i.net> In-Reply-To: <alpine.BSF.2.00.1109101149120.62958@fledge.watson.org> References: <201109090744.p897iE9x027234@svn.freebsd.org> <alpine.BSF.2.00.1109101149120.62958@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Saturday 10 September 2011 12:54:08 Robert Watson wrote: > On Fri, 9 Sep 2011, Hans Petter Selasky wrote: > > Log: > > MFC r225350 and r225400: > > > > This patch adds automatic detection of USB mass storage devices > > which does not support the no synchronize cache SCSI command. > > > > The __FreeBSD_version version macro has been bumped and > > external kernel modules needs to be recompiled after > > this patch. > > > > PR: usb/160299 > > For most other classes of hardware device driver framework KPIs -- > especially things like PCI bus attachment, busdma, CAM, ifnet, and GEOM > frameworks, our MFC rules would strictly disallow this sort of change, on > the grounds that it is our KBI policy that we not break common classes of > third-party device drivers (i.e., require them to be recompiled). My > suspicion is that we should be applying the same rules to the USB > framework -- however, I don't know if we have any third-party USB device > drivers? > > (If we do, then this change should not have been MFC'd.) Hi Robert, I understand your point. The change is not breaking any KPIs towards userspace. The structure in question is only used within the kernel and kernel modules. --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201109101310.24841.hselasky>