From owner-freebsd-perl@FreeBSD.ORG Wed Mar 7 17:40:13 2012 Return-Path: Delivered-To: perl@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 04B71106566B for ; Wed, 7 Mar 2012 17:40:13 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id E87B18FC14 for ; Wed, 7 Mar 2012 17:40:12 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q27HeCjF018575 for ; Wed, 7 Mar 2012 17:40:12 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q27HeCFT018574; Wed, 7 Mar 2012 17:40:12 GMT (envelope-from gnats) Date: Wed, 7 Mar 2012 17:40:12 GMT Message-Id: <201203071740.q27HeCFT018574@freefall.freebsd.org> To: perl@FreeBSD.org From: Paul Schmehl Cc: Subject: Re: ports/165826: [PATCH] net/p5-Net-Nessus-XMLRPC: add missing DEPENDS X-BeenThere: freebsd-perl@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Paul Schmehl List-Id: maintainer of a number of perl-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Mar 2012 17:40:13 -0000 The following reply was made to PR ports/165826; it has been noted by GNATS. From: Paul Schmehl To: bug-followup@FreeBSD.org Cc: Edwin Groothuis Subject: Re: ports/165826: [PATCH] net/p5-Net-Nessus-XMLRPC: add missing DEPENDS Date: Wed, 07 Mar 2012 11:24:46 -0600 --On March 7, 2012 11:00:46 AM -0600 Edwin Groothuis wrote: > Maintainer of net/p5-Net-Nessus-XMLRPC, > > Please note that PR ports/165826 has just been submitted. > > If it contains a patch for an upgrade, an enhancement or a bug fix > you agree on, reply to this email stating that you approve the patch > and a committer will take care of it. > > The full text of the PR can be found at: > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/165826 According to the CPAN page (), only IO::Socket::SSL is required (and in FreeBSD, Net::SSL is a RUN_DEPENDS for IO::Socket::SSL. anyway.) "'This CPAN module uses LWP for communicating with Nessus over XMLRPC via https. Therefore, make sure that you have Net::SSL (provided by Crypt::SSLeay): http://search.cpan.org/perldoc?Crypt::SSLeay or IO::Socket::SSL: http://search.cpan.org/perldoc?IO::Socket::SSL" If you want to argue that LWP is a RUN_DEPENDS, I can see that, but why HTML::Message and XML::Simple? Why does the author think these other modules are required? I need more information before making this change. Even if these other modules were required, they wouldn't be BUILD_DEPENDS, they would be RUN_DEPENDS, so the patch would need to be corrected for that. -- Paul Schmehl (pauls@utdallas.edu) Senior Information Security Analyst The University of Texas at Dallas http://www.utdallas.edu/infosecurity/