From owner-cvs-all Wed Sep 18 1:42: 3 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D9E3C37B401; Wed, 18 Sep 2002 01:42:01 -0700 (PDT) Received: from mail.musha.org (daemon.musha.org [210.189.104.8]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1DDC143E77; Wed, 18 Sep 2002 01:42:01 -0700 (PDT) (envelope-from knu@iDaemons.org) Received: from archon.local.idaemons.org (archon.local.idaemons.org [192.168.1.32]) by mail.musha.org (Postfix) with ESMTP id 74C53519B2; Wed, 18 Sep 2002 17:41:59 +0900 (JST) Date: Wed, 18 Sep 2002 17:42:00 +0900 Message-ID: <86wupj1yg7.wl@archon.local.idaemons.org> From: "Akinori MUSHA" To: David O'Brien , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/gnu/usr.bin/grep Makefile grep.1 grep.c In-Reply-To: <20020918001657.GA6110@dragon.nuxi.com> References: <200209160427.g8G4RUom036315@freefall.freebsd.org> <86ofayjsdr.wl@archon.local.idaemons.org> <86y9a05ip4.wl@archon.local.idaemons.org> <20020918001657.GA6110@dragon.nuxi.com> User-Agent: Wanderlust/2.9.15 (Unchained Melody) EMIKO/1.14.1 (Choanoflagellata) LIMIT/1.14.7 (Fujiidera) APEL/10.3 Emacs/21.2 (i386--freebsd) MULE/5.0 (SAKAKI) Organization: Associated I. Daemons X-PGP-Public-Key: finger knu@FreeBSD.org X-PGP-Fingerprint: 081D 099C 1705 861D 4B70 B04A 920B EFC7 9FD9 E1EE MIME-Version: 1.0 (generated by EMIKO 1.14.1 - "Choanoflagellata") Content-Type: text/plain; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG At Tue, 17 Sep 2002 17:16:57 -0700, o`brien wrote: > > On Wed, Sep 18, 2002 at 07:56:23AM +0900, Akinori MUSHA wrote: > > 2. Unlike gzread(), BZ2_bzread() does not work against a non-bzip2ed > > stream. (I guess BZ2_bzread() should be fixed in future because > > it claims to be compatible with gzread()) > > > > The attached patch should fix them and make `grep -J foo foo.bz2' work > > just as expected. Your code also have a flaw when both -Z and -J are specified. I think BZflag and Zflag should be made mutually exclusive, or preferably bzlib should be tweaked to have the ability to fall back onto zlib if a stream is not bzip2ed. (Then -J could be just obsoleted) > This isn't working for me with your patch: > > ''grep -J Berk COPYRIGHT'' gives nothing. Adding: lseek (bufdesc, 0, SEEK_SET); right after the BZ2_bzReadClose() call should fix that. > Also amusing is that our zgrep won't read .Z files. Hrm, who would care.. ;) -- / /__ __ Akinori.org / MUSHA.org / ) ) ) ) / FreeBSD.org / Ruby-lang.org Akinori MUSHA aka / (_ / ( (__( @ iDaemons.org / and.or.jp "When I leave I don't know what I'm hoping to find When I leave I don't know what I'm leaving behind.." To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message