From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Oct 15 22:00:18 2010 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 89BC1106566C for ; Fri, 15 Oct 2010 22:00:18 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 2DCBE8FC14 for ; Fri, 15 Oct 2010 22:00:18 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o9FM0Irt005100 for ; Fri, 15 Oct 2010 22:00:18 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o9FM0IUW005089; Fri, 15 Oct 2010 22:00:18 GMT (envelope-from gnats) Resent-Date: Fri, 15 Oct 2010 22:00:18 GMT Resent-Message-Id: <201010152200.o9FM0IUW005089@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Aldis Berjoza Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 39D6C1065670 for ; Fri, 15 Oct 2010 21:59:35 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 0E3138FC12 for ; Fri, 15 Oct 2010 21:59:35 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o9FLxYkc049368 for ; Fri, 15 Oct 2010 21:59:34 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id o9FLxYRA049367; Fri, 15 Oct 2010 21:59:34 GMT (envelope-from nobody) Message-Id: <201010152159.o9FLxYRA049367@www.freebsd.org> Date: Fri, 15 Oct 2010 21:59:34 GMT From: Aldis Berjoza To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/151482: [PATCH] lxsession doesn't build if NLS unselected X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Oct 2010 22:00:18 -0000 >Number: 151482 >Category: ports >Synopsis: [PATCH] lxsession doesn't build if NLS unselected >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Oct 15 22:00:17 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Aldis Berjoza >Release: FreeBSD-8.1-Release >Organization: >Environment: FreeBSD b32.bsdroot.lv 8.1-RELEASE FreeBSD 8.1-RELEASE #0: Sun Jul 25 01:24:28 EEST 2010 killasmurf86@root.bsdroot.lv:/usr/obj/usr/src/sys/GENERICpp i386 >Description: The binary will be installed in /usr/local/bin http://lxde.org/ Have fun! ===> Building for lxsession-0.4.4 gmake all-recursive gmake[1]: Entering directory `/usr/obj/usr/ports/x11-wm/lxsession/work/lxsession-0.4.4' Making all in lxsession gmake[2]: Entering directory `/usr/obj/usr/ports/x11-wm/lxsession/work/lxsession-0.4.4/lxsession' cc -DHAVE_CONFIG_H -I. -I.. -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -DPACKAGE_LOCALE_DIR=\""/usr/local/lib/locale"\" -Werror-implicit-function-declaration -O2 -pipe -march=pentiumpro -fno-strict-aliasing -MT lxsession-lxsession.o -MD -MP -MF .deps/lxsession-lxsession.Tpo -c -o lxsession-lxsession.o `test -f 'lxsession.c' || echo './'`lxsession.c In file included from lxsession.c:39: xevent.h:26:22: error: X11/Xlib.h: No such file or directory In file included from lxsession.c:39: xevent.h:30: error: expected '=', ',', ';', 'asm' or '__attribute__' before '*' token In file included from lxsession.c:40: settings-daemon.h:33: error: expected ')' before '*' token gmake[2]: *** [lxsession-lxsession.o] Error 1 gmake[2]: Leaving directory `/usr/obj/usr/ports/x11-wm/lxsession/work/lxsession-0.4.4/lxsession' gmake[1]: *** [all-recursive] Error 1 gmake[1]: Leaving directory `/usr/obj/usr/ports/x11-wm/lxsession/work/lxsession-0.4.4' gmake: *** [all] Error 2 *** Error code 1 Stop in /usr/ports/x11-wm/lxsession. >How-To-Repeat: cd to ports dir make config unselect NLS make >Fix: apply patch Patch attached with submission follows: diff -u lxsession.bak/Makefile lxsession/Makefile --- lxsession.bak/Makefile 2010-10-16 00:52:33.297284038 +0300 +++ lxsession/Makefile 2010-10-16 00:53:13.821369562 +0300 @@ -7,6 +7,7 @@ PORTNAME= lxsession PORTVERSION= 0.4.4 +PORTREVISION= 1 CATEGORIES= x11-wm MASTER_SITES= SF/lxde/LXSession%20%28session%20manager%29/LXSession%20${PORTVERSION} @@ -27,12 +28,13 @@ MAN1= lxsession.1 lxsession-logout.1 -.if !defined(WITHOUT_NLS) -USE_GETTEXT= yes -PLIST_SUB+= NLS="" CPPFLAGS+= -I${LOCALBASE}/include LDFLAGS+= -L${LOCALBASE}/lib CONFIGURE_ENV+= CPPFLAGS="${CPPFLAGS}" LDFLAGS="${LDFLAGS}" + +.if !defined(WITHOUT_NLS) +USE_GETTEXT= yes +PLIST_SUB+= NLS="" .else CONFIGURE_ARGS+=--disable-nls PLIST_SUB+= NLS="@comment " >Release-Note: >Audit-Trail: >Unformatted: