From owner-svn-src-all@freebsd.org Fri Mar 22 11:43:12 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BF1411541643; Fri, 22 Mar 2019 11:43:12 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 96C3F7689C; Fri, 22 Mar 2019 11:43:10 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id 7IZlhvmBwLdsa7IZnhqoxe; Fri, 22 Mar 2019 05:43:08 -0600 X-Authority-Analysis: v=2.3 cv=G9Zi7Os5 c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=NTGMnVQrEZIA:10 a=iKhvJSA4AAAA:8 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=Oi4kQeZPSxDP7k8tWo4A:9 a=CjuIK1q_8ugA:10 a=odh9cflL3HIXMm4fY7Wr:22 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id 2E470A82; Fri, 22 Mar 2019 04:43:05 -0700 (PDT) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id x2MBh4Eg005877; Fri, 22 Mar 2019 04:43:04 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id x2MBh4Ib005874; Fri, 22 Mar 2019 04:43:04 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201903221143.x2MBh4Ib005874@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: rgrimes@freebsd.org cc: Cy Schubert , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r345400 - in head/libexec/rc: . rc.d In-Reply-To: Message from "Rodney W. Grimes" of "Thu, 21 Mar 2019 22:17:11 -0700." <201903220517.x2M5HBqg063638@gndrsh.dnsmgr.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Fri, 22 Mar 2019 04:43:04 -0700 X-CMAE-Envelope: MS4wfKMRC51X7ZAeXD2Ie9QfyXF7uJhbD3Q6LBuPK/5MsOSydj/Agj/hQKGLkxxtRTru6d0NsymcidCjm6w27JAbs1xLa/x9WAdqssY0azph9UEwbb9b+8Qh Fd+5ub6Nk5xcUnbFpd+3MOXsumY4L/Zh1K8ZecrmXjsspQRDzZWLui5/wVsguLGbUL4FBFpwI9wFVk8nQHN47Dsa9mKu8QYEC6o1NqaXKF4JgqEZOOt+CHd0 EQc6vbxclxFxv6JscZALpk9XV8x7N3K9lL+fk5Tsph7VNKYlGk+i0zW6aJyYfICSvJpx6fpODfGzvuxwjmMF0w== X-Rspamd-Queue-Id: 96C3F7689C X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-4.95 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; HAS_REPLYTO(0.00)[Cy.Schubert@cschubert.com]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; MV_CASE(0.50)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; HAS_XAW(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCPT_COUNT_FIVE(0.00)[5]; REPLYTO_EQ_FROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; MX_GOOD(-0.01)[cached: spqr.komquats.com]; NEURAL_HAM_SHORT(-0.91)[-0.912,0]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[17.125.67.70.zen.spamhaus.org : 127.0.0.11]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:6327, ipnet:64.59.128.0/20, country:CA]; MIME_TRACE(0.00)[0:+]; IP_SCORE(-2.32)[ip: (-6.34), ipnet: 64.59.128.0/20(-2.93), asn: 6327(-2.25), country: CA(-0.09)]; RCVD_IN_DNSWL_LOW(-0.10)[12.134.59.64.list.dnswl.org : 127.0.5.1] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Mar 2019 11:43:13 -0000 In message <201903220517.x2M5HBqg063638@gndrsh.dnsmgr.net>, "Rodney W. Grimes" writes: > > Author: cy > > Date: Fri Mar 22 01:30:51 2019 > > New Revision: 345400 > > URL: https://svnweb.freebsd.org/changeset/base/345400 > > > > Log: > > Add rc.d support for ippool(8). > > > > I've been using ippool at my site for approximately two years. It's > > about time this was committed. > > > > PR: 218433 > > MFC after: 2 weeks > > > > Added: > > head/libexec/rc/rc.d/ippool (contents, props changed) > > Modified: > > head/libexec/rc/rc.conf > > > > Modified: head/libexec/rc/rc.conf > > =========================================================================== > === > > --- head/libexec/rc/rc.conf Thu Mar 21 23:31:10 2019 (r345399) > > +++ head/libexec/rc/rc.conf Fri Mar 22 01:30:51 2019 (r345400) > > @@ -196,6 +196,10 @@ ipfilter_program="/sbin/ipf" # where the ipfilter pr > og > > ipfilter_rules="/etc/ipf.rules" # rules definition file for ipfilter, s > ee > > # /usr/src/contrib/ipfilter/rules for examples > > ipfilter_flags="" # additional flags for ipfilter > > +ippool_enable="NO" # Set to YES to enable ip filter pools > > +ippool_program="/sbin/ippool" # where the ippool program lives > > +ippool_rules="/etc/ippool.tables" # rules definition file for ippool > > +ippool_flags="" # additional flags for ippool > > ipnat_enable="NO" # Set to YES to enable ipnat functionality > > ipnat_program="/sbin/ipnat" # where the ipnat program lives > > ipnat_rules="/etc/ipnat.rules" # rules definition file for ipnat > > > > Added: head/libexec/rc/rc.d/ippool > > =========================================================================== > === > > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > > +++ head/libexec/rc/rc.d/ippool Fri Mar 22 01:30:51 2019 (r34540 > 0) > > @@ -0,0 +1,40 @@ > > +#!/bin/sh > > +# > > +# $FreeBSD$ > > +# > > + > > +# PROVIDE: ippool > > +# REQUIRE: FILESYSTEMS > > +# BEFORE: ipfilter > > +# KEYWORD: nojail > > + > > +. /etc/rc.subr > > + > > +name="ippool" > > +desc="user interface to the IPFilter pools" > > +rcvar="ippool_enable" > > +load_rc_config $name > > +start_cmd="ippool_start" > > +stop_cmd="${ippool_program} -F" > > +reload_cmd="ippool_reload" > > +extra_commands="reload" > > +required_files="${ippool_rules}" > > +required_modules="ipl:ipfilter" > > + > > +ippool_start() > > +{ > > + if [ -r "${ippool_rules}" ]; then > > + echo "Loading IP Pools." > > + ${ippool_program} -f ${ippool_rules} ${ippool_flags} > > + fi > > +} > > + > > +ippool_reload() > > +{ > > + echo "Reloading IP Pools." > > + ${ippool_program} -F > > + ippool_start > > Couldnt this better be expressed > ${stop_cmd} > ${start_cmd} > Yes. I'll fix that. > > +} > > + > > + > > +run_rc_command "$1" > > > > > > -- > Rod Grimes rgrimes@freebsd.or > g > -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.