From owner-svn-src-all@freebsd.org Tue Dec 1 17:49:17 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 54DD2A3E8FB; Tue, 1 Dec 2015 17:49:17 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 37136105D; Tue, 1 Dec 2015 17:49:17 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [IPv6:::1]) by freefall.freebsd.org (Postfix) with ESMTP id 306361862; Tue, 1 Dec 2015 17:49:17 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id C775C147CE; Tue, 1 Dec 2015 17:49:16 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id NYJo41VNx9Ip; Tue, 1 Dec 2015 17:49:14 +0000 (UTC) Subject: Re: svn commit: r291600 - in head: lib/lib80211 share/mk DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 4E5F2147C9 To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201512011738.tB1HcqMe029403@repo.freebsd.org> From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: <565DDDA5.3040202@FreeBSD.org> Date: Tue, 1 Dec 2015 09:49:25 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <201512011738.tB1HcqMe029403@repo.freebsd.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="kLSoXWjKsThVThASwxLGWdQO6OWGar7CW" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Dec 2015 17:49:17 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --kLSoXWjKsThVThASwxLGWdQO6OWGar7CW Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/1/2015 9:38 AM, Bryan Drewery wrote: > Author: bdrewery > Date: Tue Dec 1 17:38:52 2015 > New Revision: 291600 > URL: https://svnweb.freebsd.org/changeset/base/291600 >=20 > Log: > Fix underlinking in lib80211 and define static dependencies in src.li= bnames.mk > so NO_SHARED works properly. > =20 > Reported by: Manfred Antar > Sponsored by: EMC / Isilon Storage Division >=20 > Modified: > head/lib/lib80211/Makefile > head/share/mk/src.libnames.mk >=20 > Modified: head/lib/lib80211/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/lib/lib80211/Makefile Tue Dec 1 17:31:22 2015 (r291599) > +++ head/lib/lib80211/Makefile Tue Dec 1 17:38:52 2015 (r291600) > @@ -8,6 +8,8 @@ SRCS=3D lib80211_regdomain.c lib80211_ioct > INCSDIR=3D ${INCLUDEDIR}/lib80211 > INCS=3D lib80211_regdomain.h lib80211_ioctl.h > =20 > +LIBADD=3D sbuf bsdxml > + I have a branch in progress to automatically detect underlinking like this. I did so at Isilon for internal libraries, but not FreeBSD libraries. Doing so for FreeBSD has become a massive effort just as it was for Isilon's internal libraries. There's a lot of cyclic dependencies and libraries missing from src.libnames.mk. > MAN=3D lib80211.3 > =20 > CFLAGS+=3D-I${.CURDIR} >=20 > Modified: head/share/mk/src.libnames.mk > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/share/mk/src.libnames.mk Tue Dec 1 17:31:22 2015 (r291599) > +++ head/share/mk/src.libnames.mk Tue Dec 1 17:38:52 2015 (r291600) > @@ -162,6 +162,7 @@ _LIBRARIES=3D \ > ypclnt \ > z > =20 > +_DP_80211=3D sbuf bsdxml I am adding a sanity check in src.libnames.mk for this to assert that the _DP_{lib} matches the lib's LIBADD. I consider the _DP_{lib} entries to be a bad hack but it's what we're stuck with for now until something better comes along. > _DP_archive=3D z bz2 lzma bsdxml > .if ${MK_OPENSSL} !=3D "no" > _DP_archive+=3D crypto >=20 --=20 Regards, Bryan Drewery --kLSoXWjKsThVThASwxLGWdQO6OWGar7CW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJWXd2lAAoJEDXXcbtuRpfPZd0H/0FsCZx+iJwf67KEYBMW2ASI CsEgEPUr5/lm+EULqqJmB36MfELVcE+5/Ok0aRcsdvO8+NzlhsUjQbzTJIUe8vje ii0rK3qHqQs0IMJ5Jsdv/gsuL7PpCsGOTh7Buat7q3kKEX43dNs0JKDs3BJHagoW DMNZKu5QCTnBLcDceacVHN/VfKfn9tW8PrUflq+2e1ixUqwLiMfMnfrhzEyKbhFj ycpA2MHnmnqcyEHYi4P964J3P151SR/Ph17nirVDTlXHuEcvF5v85UjaURsGq5P2 AbR/ORkn+WvvZotO7hYVHrKOR0zrPcu2oSz675LUFyd5l9DtkswVcbcBFiFEXuA= =8wPK -----END PGP SIGNATURE----- --kLSoXWjKsThVThASwxLGWdQO6OWGar7CW--