Date: Mon, 24 Jun 2013 12:46:59 +0000 (UTC) From: Attilio Rao <attilio@FreeBSD.org> To: src-committers@freebsd.org, svn-src-user@freebsd.org Subject: svn commit: r252160 - user/attilio/vmobj-readlock/sys/fs/fuse Message-ID: <201306241246.r5OCkxh2075368@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: attilio Date: Mon Jun 24 12:46:59 2013 New Revision: 252160 URL: http://svnweb.freebsd.org/changeset/base/252160 Log: Use vm_page_readahead_finish() when appropriate. Sponsored by: EMC / Isilon storage division Modified: user/attilio/vmobj-readlock/sys/fs/fuse/fuse_vnops.c Modified: user/attilio/vmobj-readlock/sys/fs/fuse/fuse_vnops.c ============================================================================== --- user/attilio/vmobj-readlock/sys/fs/fuse/fuse_vnops.c Mon Jun 24 09:57:41 2013 (r252159) +++ user/attilio/vmobj-readlock/sys/fs/fuse/fuse_vnops.c Mon Jun 24 12:46:59 2013 (r252160) @@ -1854,33 +1854,8 @@ fuse_vnop_getpages(struct vop_getpages_a */ ; } - if (i != ap->a_reqpage) { - /* - * Whether or not to leave the page activated is up in - * the air, but we should put the page on a page queue - * somewhere (it already is in the object). Result: - * It appears that emperical results show that - * deactivating pages is best. - */ - - /* - * Just in case someone was asking for this page we - * now tell them that it is ok to use. - */ - if (!error) { - fuse_vm_page_lock(m); - if (m->flags & PG_WANTED) - vm_page_activate(m); - else - vm_page_deactivate(m); - fuse_vm_page_unlock(m); - vm_page_busy_wunlock(m); - } else { - fuse_vm_page_lock(m); - vm_page_free(m); - fuse_vm_page_unlock(m); - } - } + if (i != ap->a_reqpage) + vm_page_readahead_finish(m); } fuse_vm_page_unlock_queues(); VM_OBJECT_WUNLOCK(vp->v_object);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201306241246.r5OCkxh2075368>