From owner-svn-src-head@freebsd.org  Tue Sep 18 08:17:36 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6249C1096FB7;
 Tue, 18 Sep 2018 08:17:36 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 0320284053;
 Tue, 18 Sep 2018 08:17:36 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id D2E4F338; Tue, 18 Sep 2018 08:17:35 +0000 (UTC)
Date: Tue, 18 Sep 2018 08:17:35 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Mark Johnston <markj@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r338687 - in head/sys: dev/cpuctl x86/include x86/x86
Message-ID: <20180918081735.GA44081@FreeBSD.org>
References: <201809141704.w8EH4aKd075044@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201809141704.w8EH4aKd075044@repo.freebsd.org>
User-Agent: Mutt/1.9.5 (2018-04-13)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Sep 2018 08:17:36 -0000

On Fri, Sep 14, 2018 at 05:04:36PM +0000, Mark Johnston wrote:
> New Revision: 338687
> URL: https://svnweb.freebsd.org/changeset/base/338687
> 
> Log:
>   Log a message after a successful boot-time microcode update.

Unfortunately, this had pessimized things on the unsuccessful side a bit.
(See below.)

> ...
> @@ -130,36 +148,26 @@ ucode_intel_verify(struct ucode_intel_header *hdr, siz
>  	uint32_t cksum, *data, size;
>  	int i;
>  
> -	if (resid < sizeof(struct ucode_intel_header)) {
> -		log_err("truncated update header");
> +	if (resid < sizeof(struct ucode_intel_header))
>  		return (1);
> -	}
>  	size = hdr->total_size;
>  	if (size == 0)
>  		size = UCODE_INTEL_DEFAULT_DATA_SIZE +
>  		    sizeof(struct ucode_intel_header);
>  
> -	if (hdr->header_version != 1) {
> -		log_err("unexpected header version %u", hdr->header_version);
> +	if (hdr->header_version != 1)
>  		return (1);
> -	}
> -	if (size % 16 != 0) {
> -		log_err("unexpected update size %u", hdr->total_size);
> +	if (size % 16 != 0)
>  		return (1);
> -	}
> -	if (resid < size) {
> -		log_err("truncated update");
> +	if (resid < size)
>  		return (1);
> -	}
>  
>  	cksum = 0;
>  	data = (uint32_t *)hdr;
>  	for (i = 0; i < size / sizeof(uint32_t); i++)
>  		cksum += data[i];
> -	if (cksum != 0) {
> -		log_err("checksum failed");
> +	if (cksum != 0)
>  		return (1);
> -	}
>  	return (0);

Looks like previous error messages were more detailed (truncated header,
unexpected version or size, truncated update, checksum mismatch).  Now
it all falls under "microcode verification failed".  Was this intentional?

./danfe