Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 7 Apr 2018 21:31:09 +0000 (UTC)
From:      Ian Lepore <ian@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r332258 - head/sys/dev/spibus
Message-ID:  <201804072131.w37LV9fv020077@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: ian
Date: Sat Apr  7 21:31:09 2018
New Revision: 332258
URL: https://svnweb.freebsd.org/changeset/base/332258

Log:
  Don't check for impossible NULL return from malloc(..., M_WAITOK).

Modified:
  head/sys/dev/spibus/spigen.c

Modified: head/sys/dev/spibus/spigen.c
==============================================================================
--- head/sys/dev/spibus/spigen.c	Sat Apr  7 21:25:29 2018	(r332257)
+++ head/sys/dev/spibus/spigen.c	Sat Apr  7 21:31:09 2018	(r332258)
@@ -242,15 +242,9 @@ spigen_transfer(struct cdev *cdev, struct spigen_trans
 #endif
 	transfer.tx_cmd = transfer.rx_cmd = malloc(st->st_command.iov_len,
 	    M_DEVBUF, M_WAITOK);
-	if (transfer.tx_cmd == NULL)
-		return (ENOMEM);
 	if (st->st_data.iov_len > 0) {
 		transfer.tx_data = transfer.rx_data = malloc(st->st_data.iov_len,
 		    M_DEVBUF, M_WAITOK);
-		if (transfer.tx_data == NULL) {
-			free(transfer.tx_cmd, M_DEVBUF);
-			return (ENOMEM);
-		}
 	}
 	else
 		transfer.tx_data = transfer.rx_data = NULL;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201804072131.w37LV9fv020077>