From owner-cvs-all Thu Sep 6 4:59:35 2001 Delivered-To: cvs-all@freebsd.org Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by hub.freebsd.org (Postfix) with ESMTP id 2FC6437B401; Thu, 6 Sep 2001 04:59:28 -0700 (PDT) Received: from fledge.watson.org (robert@fledge.pr.watson.org [192.0.2.3]) by fledge.watson.org (8.11.5/8.11.5) with SMTP id f86BxLP79486; Thu, 6 Sep 2001 07:59:21 -0400 (EDT) (envelope-from robert@fledge.watson.org) Date: Thu, 6 Sep 2001 07:59:21 -0400 (EDT) From: Robert Watson X-Sender: robert@fledge.watson.org To: "Michael C . Wu" Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/gx if_gx.c if_gxreg.h if_gxvar.h In-Reply-To: <200109060345.f863jxk78123@freefall.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Unfortunately, your commit message neglected to identify what card exactly this commit adds support for. I've noticed a tendancy among a number of committers lately to do this (David explained that he didn't have time to figure out what the bug was that he fixed, it was easier just to say he fixed a bug). My recommendation to committers would be that they formulate commit messages to be meaningful to their readers, not as an obligation to the cvs command--cvs messages are one of the only ways to keep abreast of such a large and rapdily moving source base. :-) Robert N M Watson FreeBSD Core Team, TrustedBSD Project robert@fledge.watson.org NAI Labs, Safeport Network Services On Wed, 5 Sep 2001, Michael C . Wu wrote: > keichii 2001/09/05 20:45:59 PDT > > Added files: > sys/dev/gx if_gx.c if_gxreg.h if_gxvar.h > Log: > Add a new NIC driver into the system. > > MFC after: 14 days > > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message