From owner-svn-src-projects@FreeBSD.ORG Thu Jun 18 15:03:07 2009 Return-Path: Delivered-To: svn-src-projects@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BFCFB106564A; Thu, 18 Jun 2009 15:03:07 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (cl-162.ewr-01.us.sixxs.net [IPv6:2001:4830:1200:a1::2]) by mx1.freebsd.org (Postfix) with ESMTP id 31C438FC1D; Thu, 18 Jun 2009 15:03:07 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (localhost [127.0.0.1]) by lor.one-eyed-alien.net (8.14.3/8.14.3) with ESMTP id n5IF3IV3056613; Thu, 18 Jun 2009 10:03:18 -0500 (CDT) (envelope-from brooks@lor.one-eyed-alien.net) Received: (from brooks@localhost) by lor.one-eyed-alien.net (8.14.3/8.14.3/Submit) id n5IF3Itr056612; Thu, 18 Jun 2009 10:03:18 -0500 (CDT) (envelope-from brooks) Date: Thu, 18 Jun 2009 10:03:18 -0500 From: Brooks Davis To: Andriy Gapon Message-ID: <20090618150318.GD46033@lor.one-eyed-alien.net> References: <200906171940.n5HJerMr086037@svn.freebsd.org> <4A3A10D5.8000601@freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="0H629O+sVkh21xTi" Content-Disposition: inline In-Reply-To: <4A3A10D5.8000601@freebsd.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (lor.one-eyed-alien.net [127.0.0.1]); Thu, 18 Jun 2009 10:03:18 -0500 (CDT) Cc: svn-src-projects@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r194389 - projects/ngroups/sys/kern X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jun 2009 15:03:08 -0000 --0H629O+sVkh21xTi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 18, 2009 at 01:03:01PM +0300, Andriy Gapon wrote: > on 17/06/2009 22:40 Brooks Davis said the following: > > Author: brooks > > Date: Wed Jun 17 19:40:53 2009 > > New Revision: 194389 > > URL: http://svn.freebsd.org/changeset/base/194389 > >=20 > > Log: > > use MIN() instead of min() in one case. >=20 > I think 'what' was pretty obvious from the diff, 'why' is what I am curio= us about :-) > Just trying to learn something. Because the file already used MIN and all the other cases in the system that involve some form on ngroups also use MIN. -- Brooks > > Modified: > > projects/ngroups/sys/kern/kern_prot.c > >=20 > > Modified: projects/ngroups/sys/kern/kern_prot.c > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- projects/ngroups/sys/kern/kern_prot.c Wed Jun 17 19:01:47 2009 (r19= 4388) > > +++ projects/ngroups/sys/kern/kern_prot.c Wed Jun 17 19:40:53 2009 (r19= 4389) > > @@ -1899,7 +1899,7 @@ cru2x(struct ucred *cr, struct xucred *x > > xcr->cr_version =3D XUCRED_VERSION; > > xcr->cr_uid =3D cr->cr_uid; > > =20 > > - ngroups =3D min(cr->cr_ngroups, XU_NGROUPS); > > + ngroups =3D MIN(cr->cr_ngroups, XU_NGROUPS); > > xcr->cr_ngroups =3D ngroups; > > bcopy(cr->cr_groups, xcr->cr_groups, > > ngroups * sizeof(*cr->cr_groups)); >=20 >=20 > --=20 > Andriy Gapon >=20 --0H629O+sVkh21xTi Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iD8DBQFKOlc2XY6L6fI4GtQRAkq0AKDVtN4yznD7m38XRyhSk97hTscDLgCfaGSA 5nfjVoHID0RYaCixdNb2eNg= =JUT4 -----END PGP SIGNATURE----- --0H629O+sVkh21xTi--