From owner-svn-src-all@FreeBSD.ORG  Fri Mar  2 14:05:50 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 72E56106564A;
	Fri,  2 Mar 2012 14:05:50 +0000 (UTC) (envelope-from ru@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c])
	by mx1.freebsd.org (Postfix) with ESMTP id 5E6C38FC14;
	Fri,  2 Mar 2012 14:05:50 +0000 (UTC)
Received: from svn.freebsd.org (localhost [127.0.0.1])
	by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id q22E5oSQ033408;
	Fri, 2 Mar 2012 14:05:50 GMT (envelope-from ru@svn.freebsd.org)
Received: (from ru@localhost)
	by svn.freebsd.org (8.14.4/8.14.4/Submit) id q22E5oCj033406;
	Fri, 2 Mar 2012 14:05:50 GMT (envelope-from ru@svn.freebsd.org)
Message-Id: <201203021405.q22E5oCj033406@svn.freebsd.org>
From: Ruslan Ermilov <ru@FreeBSD.org>
Date: Fri, 2 Mar 2012 14:05:50 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
	svn-src-head@freebsd.org
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: 
Subject: svn commit: r232393 - head/lib/libc/gen
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Mar 2012 14:05:50 -0000

Author: ru
Date: Fri Mar  2 14:05:50 2012
New Revision: 232393
URL: http://svn.freebsd.org/changeset/base/232393

Log:
  Removed excessive _seekdir() call in closedir().  This saves one lseek()
  syscall.  Before r5958, seekdir() was called for its side effect of
  freeing memory allocated by opendir() for rewinddir(), but that revision
  added _reclaim_telldir() that frees all memory allocated by telldir()
  calls, making this call redundant.
  
  This introduces a slight change.  If an application duplicated the descriptor
  obtained through dirfd(), it can no longer rely on file position to be
  reset to the start of file after a call to closedir().  It's believed to
  be safe because neither POSIX, nor any other OS I've tested (NetBSD, Linux,
  OS X) rewind the file offset pointer on closedir().
  
  Reported by:	Igor Sysoev

Modified:
  head/lib/libc/gen/closedir.c

Modified: head/lib/libc/gen/closedir.c
==============================================================================
--- head/lib/libc/gen/closedir.c	Fri Mar  2 13:19:56 2012	(r232392)
+++ head/lib/libc/gen/closedir.c	Fri Mar  2 14:05:50 2012	(r232393)
@@ -48,14 +48,12 @@ __FBSDID("$FreeBSD$");
  * close a directory.
  */
 int
-closedir(dirp)
-	DIR *dirp;
+closedir(DIR *dirp)
 {
 	int fd;
 
 	if (__isthreaded)
 		_pthread_mutex_lock(&dirp->dd_lock);
-	_seekdir(dirp, dirp->dd_rewind);	/* free seekdir storage */
 	fd = dirp->dd_fd;
 	dirp->dd_fd = -1;
 	dirp->dd_loc = 0;