From owner-dev-commits-ports-all@freebsd.org Mon Sep 27 19:48:31 2021 Return-Path: Delivered-To: dev-commits-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2331B66E649 for ; Mon, 27 Sep 2021 19:48:31 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HJCqg071vz4g4X for ; Mon, 27 Sep 2021 19:48:31 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: from mail-qv1-f53.google.com (mail-qv1-f53.google.com [209.85.219.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: sunpoet) by smtp.freebsd.org (Postfix) with ESMTPSA id D200655F9 for ; Mon, 27 Sep 2021 19:48:30 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: by mail-qv1-f53.google.com with SMTP id a14so11910607qvb.6 for ; Mon, 27 Sep 2021 12:48:30 -0700 (PDT) X-Gm-Message-State: AOAM532sNQFgCn6iml6znG9YTNlgN9R9qU+AqvsJjo/axS0P7IZmKLAV 7kR7KzHW/hZE9IZua+um52moqCPv1YNaJ3m/kZPHzQ== X-Google-Smtp-Source: ABdhPJzG5KwWkwk1hgR31K5vSbg0Cb16o4pNT6yaXS5hRMzqofEA3LxGi4KknzfyG2ihfRZgV1rIuqTZNd+E9QQDqC4= X-Received: by 2002:a0c:e3d3:: with SMTP id e19mr1455866qvl.46.1632772110455; Mon, 27 Sep 2021 12:48:30 -0700 (PDT) MIME-Version: 1.0 References: <202109271550.18RFoZuU023509@gitrepo.freebsd.org> In-Reply-To: <202109271550.18RFoZuU023509@gitrepo.freebsd.org> From: Po-Chuan Hsieh Date: Tue, 28 Sep 2021 03:47:54 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: a642f92e86d3 - main - misc/py-pexpect: fix most of the test cases To: =?UTF-8?B?U3RlZmFuIEXDn2Vy?= Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: dev-commits-ports-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the ports repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Sep 2021 19:48:31 -0000 On Mon, Sep 27, 2021 at 11:50 PM Stefan E=C3=9Fer wrote: > The branch main has been updated by se: > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=3Da642f92e86d3b022e67d99f1c1dbd= 9fe6499c634 > > commit a642f92e86d3b022e67d99f1c1dbd9fe6499c634 > Author: Stefan E=C3=9Fer > AuthorDate: 2021-09-27 13:49:11 +0000 > Commit: Stefan E=C3=9Fer > CommitDate: 2021-09-27 15:49:50 +0000 > > misc/py-pexpect: fix most of the test cases > > A number of test cases included in the pexpect distribution failed on > FreeBSD. The patches included in the commit fix most of these tests. > > One of the tests used /bin/bash and long options for the nl command. > Other tests assumed pipe buffers larger than provided by FreeBSD. > > 3 tests are still failing: > > tests/test_replwrap.py::REPLWrapTestCase::test_existing_spawn FAILED > > The text received contains bracketed paste escape characters when > a bash version 5.1 or newer is installed. There may be another proble= m > with this test, though, since it seems to depend on some bash rc file > of the account executing this test. > > tests/test_socket.py::ExpectTestCase::test_interrupt FAILED > tests/test_socket.py::ExpectTestCase::test_multiple_interrupts FAILED > > These two test seem to fail due to an early exit of the sending > process. It appears to be in Zombie state and cannot be signaled. > The "non-blocking read" seems to be blocking in this situation. > > The real cause is unclear, it seems to be a mismatch between process > lifetime semantics in Linux and FreeBSD. I have removed an infinite > wait loop with these patches, which causes a test failure to be > detected (instead of preventing the execution of any further test > cases). > > I have created a pull request on Github to get these patches into the > upstream, but it seems that the owner of the pexpect repository is no= t > very active. > > Approved by: sunpoet (maintainer) > Stefan, thanks for fixing it! Regards, sunpoet