Date: Thu, 31 Mar 2011 13:29:11 -0600 From: Warner Losh <imp@bsdimp.com> To: John Baldwin <jhb@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, Adrian Chadd <adrian@FreeBSD.org>, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org Subject: Re: svn commit: r220185 - in head/sys: amd64/conf arm/conf conf dev/ath i386/conf mips/conf modules modules/ath modules/ath_ahb modules/ath_pci pc98/conf sparc64/conf Message-ID: <73CB36BD-1C9E-4992-A3C7-B540ABB7F11E@bsdimp.com> In-Reply-To: <201103310740.20265.jhb@freebsd.org> References: <201103310807.p2V87DHV096049@svn.freebsd.org> <201103310740.20265.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mar 31, 2011, at 5:40 AM, John Baldwin wrote: > On Thursday, March 31, 2011 4:07:13 am Adrian Chadd wrote: >> Author: adrian >> Date: Thu Mar 31 08:07:13 2011 >> New Revision: 220185 >> URL: http://svn.freebsd.org/changeset/base/220185 >>=20 >> Log: >> Break out the ath PCI logic into a separate device/module. >>=20 >> Introduce the AHB glue for Atheros embedded systems. Right now it's >> hard-coded for the AR9130 chip whose support isn't yet in this HAL; >> it'll be added in a subsequent commit. >>=20 >> Kernel configuration files now need both 'ath' and 'ath_pci' = devices; both >> modules need to be loaded for the ath device to work. >=20 > Err, there's no need to break the kernel config. Just have the kernel = DTRT if=20 > both ath and pci are enabled using something like: >=20 > sys/dev/ath/if_ath_pci.c ath pci >=20 > in sys/conf/files. >=20 > You can still have an if_ath_pci.ko module with this arrangement. = This is=20 > what almost all other drivers due that have multiple bus backends. Well, most drivers with multiple back ends compile all the relevant ones = for the platform in. There's very few that call out individual ones = (ata and its kin being the big exception). Personally, I'd not bother having a if_ath_pci.ko, and instead bundle it = in with if_ath.ko and omitting if_ath_ahb.c from the x86 builds, but I = understand why this might be important in the embedded builds. Warner=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?73CB36BD-1C9E-4992-A3C7-B540ABB7F11E>