From owner-freebsd-x11@FreeBSD.ORG Tue Apr 24 19:41:33 2012 Return-Path: Delivered-To: freebsd-x11@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 94360106566B for ; Tue, 24 Apr 2012 19:41:33 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 15A7B8FC12 for ; Tue, 24 Apr 2012 19:41:32 +0000 (UTC) Received: from skuns.kiev.zoral.com.ua (localhost [127.0.0.1]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id q3OJfNA6097494; Tue, 24 Apr 2012 22:41:23 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5) with ESMTP id q3OJfN1h040407; Tue, 24 Apr 2012 22:41:23 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5/Submit) id q3OJfNWu040406; Tue, 24 Apr 2012 22:41:23 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 24 Apr 2012 22:41:23 +0300 From: Konstantin Belousov To: Jose Garcia Juanino Message-ID: <20120424194123.GC2358@deviant.kiev.zoral.com.ua> References: <20120424184459.GB2455@banach> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="4iaqbKIO7LGyq7R2" Content-Disposition: inline In-Reply-To: <20120424184459.GB2455@banach> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.0 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: freebsd-x11@freebsd.org Subject: Re: Loading i915 module panics my system after patching with Intel GPU patch 14.4 for stable/9 X-BeenThere: freebsd-x11@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: X11 on FreeBSD -- maintaining and support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Apr 2012 19:41:33 -0000 --4iaqbKIO7LGyq7R2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 24, 2012 at 08:45:00PM +0200, Jose Garcia Juanino wrote: > Hi, >=20 > Scenario: 9.0-STABLE FreeBSD r234656M: >=20 > VGA chipset is: >=20 > vgapci0@pci0:0:2:0: class=3D0x030000 card=3D0x01631028 chip=3D0x35828= 086 > rev=3D0x02 hdr=3D0x00 > vendor =3D 'Intel Corporation' > device =3D '82852/855GM Integrated Graphics Device' > class =3D display > subclass =3D VGA > vgapci1@pci0:0:2:1: class=3D0x038000 card=3D0x01631028 > chip=3D0x35828086 rev=3D0x02 hdr=3D0x00 > vendor =3D 'Intel Corporation' > device =3D '82852/855GM Integrated Graphics > Device' > class =3D display >=20 > Before apply drm-all.14.4-stable9.1.patch, I can kldload i915, and I > get: >=20 > drm0: on vgapci0 > info: [drm] AGP at 0xf0000000 128MB > info: [drm] Initialized i915 1.6.0 20080730 >=20 > After applying the patch, I get a panic: >=20 > http://www.mipaginapersonal.movistar.es/web3/jjuanino/core.txt.1 >=20 > Any advice will be wellcome. Apply the patch below on top of 14.4. Most likely, it would cure the panic on agp attach failure. Anyway, enable verbose booting, and show me the kernel messages after kldload i915 is initiated for 14.4 + patch below. commit 068914b4d6e4ed34d030f7d4dca361afb3a413af Author: Konstantin Belousov Date: Tue Apr 24 22:36:05 2012 +0300 Try to fix the panic on emergency unload. Be more informative when reporting memory config problems. =20 Reported by: Jose Garcia Juanino diff --git a/sys/dev/agp/agp_i810.c b/sys/dev/agp/agp_i810.c index 54777d3..1b0c60d 100644 --- a/sys/dev/agp/agp_i810.c +++ b/sys/dev/agp/agp_i810.c @@ -991,7 +991,9 @@ agp_i830_get_stolen_size(device_t dev) break; default: sc->stolen =3D 0; - device_printf(dev, "unknown memory configuration, disabling\n"); + device_printf(dev, + "unknown memory configuration, disabling (GCC1 %x)\n", + gcc1); return (EINVAL); } return (0); @@ -1125,7 +1127,9 @@ agp_i915_get_stolen_size(device_t dev) stolen =3D 0; break; default: - device_printf(dev, "unknown memory configuration, disabling\n"); + device_printf(dev, + "unknown memory configuration, disabling (GCC1 %x)\n", + gcc1); return (EINVAL); } =20 diff --git a/sys/dev/drm/drm_drv.c b/sys/dev/drm/drm_drv.c index b9b8504..1be544f 100644 --- a/sys/dev/drm/drm_drv.c +++ b/sys/dev/drm/drm_drv.c @@ -575,7 +575,8 @@ error: DRM_LOCK(); drm_lastclose(dev); DRM_UNLOCK(); - destroy_dev(dev->devnode); + if (dev->devnode !=3D NULL) + destroy_dev(dev->devnode); =20 mtx_destroy(&dev->drw_lock); mtx_destroy(&dev->vbl_lock); @@ -594,7 +595,8 @@ static void drm_unload(struct drm_device *dev) DRM_DEBUG("\n"); =20 drm_sysctl_cleanup(dev); - destroy_dev(dev->devnode); + if (dev->devnode !=3D NULL) + destroy_dev(dev->devnode); =20 drm_ctxbitmap_cleanup(dev); =20 --4iaqbKIO7LGyq7R2 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAk+XAeIACgkQC3+MBN1Mb4ilywCg3c9JJeuXvCZ/+pWTDKrwvmAK 0lQAn1nQGhwwaVGWQDZp1lYY7QwF7CA3 =oJT5 -----END PGP SIGNATURE----- --4iaqbKIO7LGyq7R2--