Date: Wed, 11 Dec 2002 10:40:04 +0100 From: Stijn Hoop <stijn@win.tue.nl> To: Peter Pentchev <roam@ringlet.net> Cc: Lamont Granquist <lamont@scriptkiddie.org>, Dmitry Morozovsky <marck@rinet.ru>, freebsd-hackers@freebsd.org Subject: Re: CVS_LOCAL_BRANCH_NUM? Message-ID: <20021211094004.GC52865@pcwin002.win.tue.nl> In-Reply-To: <20021211085954.GB371@straylight.oblivion.bg> References: <20021210201135.H10798-100000@woozle.rinet.ru> <20021210115422.T3061-100000@coredump.scriptkiddie.org> <20021211085954.GB371@straylight.oblivion.bg>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Wed, Dec 11, 2002 at 10:59:55AM +0200, Peter Pentchev wrote:
> On Tue, Dec 10, 2002 at 11:56:26AM -0800, Lamont Granquist wrote:
> > On Tue, 10 Dec 2002, Dmitry Morozovsky wrote:
> > > Please note quotes explicitly, "$@" is really needed where your parameters
> > > contain spaces (bad practice in filenames, yeah, but don't make yourself
> > > another one PITA you can avoid ;-P )
> >
> > got it.
>
> Mmm.. I am not really sure if we need quotes in this particular case.
> In my experience, the CVS invocation in the server or pserver case
> almost always has more than one argument (at the very least, the
> 'server' or 'pserver' keyword and one 'allow-root' option). The quotes
> around "$@" would make the whole param string be passed as a single
> parameter to the "real" CVS binary, which might not be quite the desired
> result...
No, that's not the behaviour with /bin/sh, from the man page:
@ Expands to the positional parameters, starting from one. When
the expansion occurs within double-quotes, each positional param-
eter expands as a separate argument. If there are no positional
parameters, the expansion of @ generates zero arguments, even
when @ is double-quoted. What this basically means, for example,
is if $1 is ``abc'' and $2 is ``def ghi'', then "$@" expands to
the two arguments:
"abc" "def ghi"
I think "$@" (with the quotes) is ok.
--Stijn
--
Help Wanted: Telepath. You know where to apply.
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (FreeBSD)
iD8DBQE99wf0Y3r/tLQmfWcRAjhmAJ96nAy17A64ghe7ImDgVAKp5qULYwCgoPle
Sy1QeXfxA2xdGlchs0wWrcY=
=KsS1
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021211094004.GC52865>