From owner-cvs-all@FreeBSD.ORG  Thu Aug  3 03:34:37 2006
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9FD3116A4E0;
	Thu,  3 Aug 2006 03:34:37 +0000 (UTC)
	(envelope-from delphij@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 7295B43D45;
	Thu,  3 Aug 2006 03:34:37 +0000 (GMT)
	(envelope-from delphij@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k733YbIS052987;
	Thu, 3 Aug 2006 03:34:37 GMT
	(envelope-from delphij@repoman.freebsd.org)
Received: (from delphij@localhost)
	by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k733Ybwd052986;
	Thu, 3 Aug 2006 03:34:37 GMT (envelope-from delphij)
Message-Id: <200608030334.k733Ybwd052986@repoman.freebsd.org>
From: Xin LI <delphij@FreeBSD.org>
Date: Thu, 3 Aug 2006 03:34:37 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Cc: 
Subject: cvs commit: src/lib/libc/uuid uuid_compare.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Aug 2006 03:34:37 -0000

delphij     2006-08-03 03:34:36 UTC

  FreeBSD src repository

  Modified files:
    lib/libc/uuid        uuid_compare.c 
  Log:
  In DCE 1.1, the time_low value is defined as an unsigned 32-bit
  integer.  Presently, our implementation employs an approach that
  converts the value to int64_t, then back to int, unfortunately,
  this approach can be problematic when the the difference between
  the two time_low is larger than 0x7fffffff, as the value is then
  truncated to int.
  
  To quote the test case from the original PR, the following is
  true with the current implementation:
  
  865e1a56-b9d9-11d9-ba27-0003476f2e88 < 062ac45c-b9d9-11d9-ba27-0003476f2e88
  
  However, according to the DCE specification, the expected result
  should be:
  
  865e1a56-b9d9-11d9-ba27-0003476f2e88 > 062ac45c-b9d9-11d9-ba27-0003476f2e88
  
  This commit adds a new intermediate variable which uses int64_t
  to store the result of subtraction between the two time_low values,
  which would not introduce different semantic of the MSB found in
  time_low value.
  
  PR:             83107
  Submitted by:   Steve Sears <sjs at acm dot org>
  MFC After:      1 month
  
  Revision  Changes    Path
  1.5       +15 -5     src/lib/libc/uuid/uuid_compare.c