Date: Fri, 12 Apr 2019 15:42:49 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 237215] games/diaspora: fix build with GCC-based architectures Message-ID: <bug-237215-7788-Ct7BAxTdE5@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-237215-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-237215-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D237215 --- Comment #1 from lightside <lightside@gmx.com> --- Hello. Thanks for PR and patch submission. As I understood, the provided build log mentions about GCC 4.2.1 compiler: _CCVERSION_921dbbb2=3Dcc (GCC) 4.2.1 20070831 patched [FreeBSD] <..> I checked build with using newer GCC 8.3 compiler (lang/gcc8, USE_GCC=3Dyes= ) (at least on amd64 architecture, but mentioned compiler errors might be the sam= e) and it builds without errors. The newer GCC 8.3 compiler doesn't require CXXFLAGS+=3D-fpermissive for this case also. This may mean, that this is GCC 4.2.1 (or 4.x) related compiler issue. The ".if exists(/usr/lib/libstdc++.so)" (in attachment #203608) is inderect check for installed GCC 4.2.1 compiler in FreeBSD base, if I'm not wrong. T= here are cases in current FreeBSD ports for such check. But maybe possible to add some comment about GCC 4.2.1 related issue for this case. I guess, that possible alternative approach is explicit check for GCC compi= ler version, for example: -8<-- USES+=3D compiler .include <bsd.port.pre.mk> .if ${CHOSEN_COMPILER_TYPE} =3D=3D gcc && ${COMPILER_VERSION} < 43 CXXFLAGS+=3D -fpermissive .endif # <..> .include <bsd.port.post.mk> -->8- (In reply to comment #0) > While here, also add USES=3Dgl. You also proposed to add sdl to USES. There is a space character between "+=3D" and "-fpermissive" on 76 (19 in p= atch) line in attachment #203608: "WARN: Makefile: [76]: use a tab (not space) af= ter a variable name". Please fix this and I may approve this patch. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-237215-7788-Ct7BAxTdE5>