From owner-svn-src-all@FreeBSD.ORG Thu Nov 21 23:29:44 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4479D242 for ; Thu, 21 Nov 2013 23:29:44 +0000 (UTC) Received: from mail-lb0-f169.google.com (mail-lb0-f169.google.com [209.85.217.169]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id C21822071 for ; Thu, 21 Nov 2013 23:29:43 +0000 (UTC) Received: by mail-lb0-f169.google.com with SMTP id y6so369003lbh.0 for ; Thu, 21 Nov 2013 15:29:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=lP1ygXqlcaFSGybC6Uh7vbOYz0HDyJhdTVPXaFrYlCQ=; b=dWOwK5lzMBE4xg3NFinGOnVAbgdBejtqV7o8/vErUz9j/fthgx6Xz87yZ5VrIYoBHI w8yTTlBwQaq4POzVs3aBhd/7YlYa5m1vy/i4XUC9qtuVR2uQrV2zlqV4xl1jbe7jO3IB 6UOIFQFEjeOVOpb5BFm3k8XVMOdfn8zWJLNKJKK0GduUMUyMrDJN0KC0at6j87OsavRf mcrpdUtFEMKo8089l8vX5iSvXoLqUez9K7Y6/qoLoa7KlS3CvS0NRut6lBOfHt6cg5xF Yqe6uhVMGQow6Tt37AErsCv+TX97xcACY9WYRiwPUQ0yqv7JY4QNnvZJEvEeNi0GxupJ pWkA== X-Gm-Message-State: ALoCoQn6CXsQjsgyWEo2wCd3qY1okWTxu5DunRy7kaNlEph+ykMxKsR3UUyB72/1g3kyAMc4Xp6d X-Received: by 10.112.158.231 with SMTP id wx7mr2793989lbb.27.1385076575634; Thu, 21 Nov 2013 15:29:35 -0800 (PST) MIME-Version: 1.0 Received: by 10.112.181.169 with HTTP; Thu, 21 Nov 2013 15:29:15 -0800 (PST) X-Originating-IP: [2620:0:1003:1007:e1a0:7089:8f4f:6f0d] In-Reply-To: <20131119003307.9E25A5807E@chaos.jnpr.net> References: <201311172312.rAHNCtOY010186@svn.freebsd.org> <20131119003307.9E25A5807E@chaos.jnpr.net> From: Julio Merino Date: Thu, 21 Nov 2013 18:29:15 -0500 Message-ID: Subject: Re: svn commit: r258285 - in head/lib/atf: libatf-c++/tests libatf-c/tests tests/test-programs To: "Simon J. Gerraty" Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Nov 2013 23:29:44 -0000 On Mon, Nov 18, 2013 at 7:33 PM, Simon J. Gerraty wrote: > > On Sun, 17 Nov 2013 23:12:55 +0000, Julio Merino writes: >> I am not sure how this ever worked before given that manual inspection >> of bsd.progs.mk clearly shows that the expected character between the >> two components is a dot and not an underscore... but I suspect the > > Actually . or _ worked, until recently. I think only supporting one form is better in the name of simplicity. > Will fix. Garrett also mentioned to me that we should not be required to explicitly set SRCS.*: when building various programs, each of them should be able to determine a reasonable value for this variable on its own. In other words, what I did in r258298 should probably not be required. What do you think? -- Julio Merino / @jmmv