From owner-cvs-all@FreeBSD.ORG  Sun Aug 12 17:35:06 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1BB5216A419;
	Sun, 12 Aug 2007 17:35:06 +0000 (UTC)
	(envelope-from kientzle@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 0ABFC13C46C;
	Sun, 12 Aug 2007 17:35:06 +0000 (UTC)
	(envelope-from kientzle@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7CHZ5OE005045;
	Sun, 12 Aug 2007 17:35:05 GMT
	(envelope-from kientzle@repoman.freebsd.org)
Received: (from kientzle@localhost)
	by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7CHZ5g9005044;
	Sun, 12 Aug 2007 17:35:05 GMT (envelope-from kientzle)
Message-Id: <200708121735.l7CHZ5g9005044@repoman.freebsd.org>
From: Tim Kientzle <kientzle@FreeBSD.org>
Date: Sun, 12 Aug 2007 17:35:05 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Cc: 
Subject: cvs commit: src/lib/libarchive archive_write_disk.c
 src/lib/libarchive/test test_write_disk_perms.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 12 Aug 2007 17:35:06 -0000

kientzle    2007-08-12 17:35:05 UTC

  FreeBSD src repository

  Modified files:
    lib/libarchive       archive_write_disk.c 
    lib/libarchive/test  test_write_disk_perms.c 
  Log:
  Make suid/sgid restore be "opportunistic" if
  owner restore is not requested.  If you ask
  for permissions to be restored but not owner,
  you will now get no error if suid/sgid bits
  cannot be set.  (It's a security hole to restore
  suid/sgid bits if the owner/group aren't restored.)
  
  This fixes an obscure problem where a simple
  "tar -xf" with no other options will sometimes
  fail gratuitously because of suid/sgid bits.
  This is causing occasional problems for people
  using bsdtar as a drop-in replacement for
  "that other tar program." ;-)
  
  Note: If you do ask for owner restore, then suid/sgid
  restore failures still issue an error.  This
  only suppresses the error in the case where an
  suid/sgid bit restore fails because of an owner
  mismatch and owner restore was not requested.
  
  Approved by: re (bmah)
  MFC after: 7 days
  
  Revision  Changes    Path
  1.14      +22 -6     src/lib/libarchive/archive_write_disk.c
  1.7       +60 -10    src/lib/libarchive/test/test_write_disk_perms.c