Date: Sat, 13 Dec 2014 11:19:10 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 195014] [NEW PORT] games/diaspora: Single and multiplayer space fighter combat game Message-ID: <bug-195014-13-RSDjY3OV7A@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-195014-13@https.bugs.freebsd.org/bugzilla/> References: <bug-195014-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D195014 --- Comment #27 from Jan Beich <jbeich@vfemail.net> --- Comment on attachment 149580 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D149580 The port in shar format The port quality is already good but there're a few minor nits: >XLICENSE_NAME_CCBYNCSAv3=3D Creative Commons Attribution-NonCommercial-Sha= reAlike 3.0 Unported license CCbyNCSA3 spelling is more common under games/. >XSPEECH_CONFIGURE_ON=3D --enable-speech Use SPEECH_CONFIGURE_ENABLE=3Dspeech unless --disable-speech is broken. >X.if ${PORT_OPTIONS:MINCJOYBTNS} >XEXTRA_PATCHES=3D ${FILESDIR}/extra-patch-increase_joy_buttons_fixed.patch >X.endif Can you leverage option helpers? =20 INCJOYBTNS_EXTRA_PATCHES=3D${FILESDIR}/extra-patch-increase_joy_buttons_fix= ed.patch >Xpost-install: >X# Add empty directories to TMPPLIST >X (cd ${STAGEDIR}${DATADIR} && ${FIND} data -type d -empty | ${SORT} |\ >X ${XARGS} -L 1 -I '{}' ${ECHO_CMD} "@dir ${DATADIR}/{}"\ >X >> ${TMPPLIST}) Nowadays, pkg-delete(8) removes empty dirs under PREFIX automatically but even before that PORTDATA added @dirrm recursively. One may want @dir the game doesn't run without *some* empty directories or if some of the data is mutable (games group) but cannot live under /var/games. >X.if ${PORT_OPTIONS:MWXLAUNCHER} >X# Create a symbolic link and add it to TMPPLIST, which used by launcher >X ${LN} -sf ${PREFIX}/libexec/fs2_open_${PORTNAME} ${STAGEDIR}${DATADIR} Why ${LN} line here and not under do-install? It's perfectly legal to make links to non-existing files. /etc/malloc.conf is notorious example. >X ${ECHO_CMD} ${DATADIR}/fs2_open_${PORTNAME} >> ${TMPPLIST} Why not replace with PLIST_FILES ? >sed 's/^X//' >diaspora/files/extra-patch-increase_joy_buttons_fixed.patch = << 'd26dbe503c4133ddd5e224c46d369bc0' >XIndex: code/controlconfig/controlsconfigcommon.cpp >X=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >X--- code/controlconfig/controlsconfigcommon.cpp (revision 8781) >X+++ code/controlconfig/controlsconfigcommon.cpp (working copy) Can you include a comment about origin of the patch? It may help track upstreaming state for the next maintainer. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-195014-13-RSDjY3OV7A>