From owner-cvs-ports@FreeBSD.ORG Mon Aug 30 07:31:19 2010 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 637EA106566B; Mon, 30 Aug 2010 07:31:19 +0000 (UTC) (envelope-from jadawin@tuxaco.net) Received: from huppa.tuxaco.net (unknown [IPv6:2001:41d0:1:66c1::1]) by mx1.freebsd.org (Postfix) with ESMTP id 1F77F8FC1A; Mon, 30 Aug 2010 07:31:19 +0000 (UTC) Received: from huppa.tuxaco.net (unknown [127.0.0.1]) by huppa.tuxaco.net (Postfix) with ESMTP id 6AB8C22988; Mon, 30 Aug 2010 09:33:58 +0200 (CEST) X-Virus-Scanned: amavisd-new at tuxaco.net Received: from huppa.tuxaco.net ([127.0.0.1]) by huppa.tuxaco.net (huppa.tuxaco.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eApGFtppGg8c; Mon, 30 Aug 2010 09:33:56 +0200 (CEST) Received: from localhost (unknown [93.182.201.235]) (Authenticated sender: jadawin@tuxaco.net) by huppa.tuxaco.net (Postfix) with ESMTPA id EA9B722987; Mon, 30 Aug 2010 09:33:55 +0200 (CEST) Date: Mon, 30 Aug 2010 09:31:18 +0200 From: Philippe =?iso-8859-1?Q?Aud=E9oud?= To: Andrej Zverev Message-ID: <20100830073118.GB66550@tuxaco.net> References: <201008291740.o7THeQJN019384@repoman.freebsd.org> <20100830070243.GA66550@tuxaco.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Cc: cvs-ports@freebsd.org, Baptiste Daroussin , cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/devel/p5-DateTime-Format-Epoch Makefile distinfo X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Aug 2010 07:31:19 -0000 On Mon, 30 Aug 2010, Andrej Zverev wrote: > 2010/8/30 Philippe Aud=E9oud : > > On Mon, 30 Aug 2010, Andrej Zverev wrote: > > > >> On Sun, Aug 29, 2010 at 9:40 PM, Baptiste Daroussin = wrote: > >> > bapt =A0 =A0 =A0 =A02010-08-29 17:40:26 UTC > >> > > >> > =A0FreeBSD ports repository > >> > > >> > =A0Modified files: > >> > =A0 =A0devel/p5-DateTime-Format-Epoch Makefile distinfo > >> > =A0Log: > >> > =A0- Really update to 0.13 > >> > =A0Approved by: =A0 =A0mentors (implicit) > >> > > >> > =A0Revision =A0Changes =A0 =A0Path > >> > =A01.16 =A0 =A0 =A0+1 -1 =A0 =A0 =A0ports/devel/p5-DateTime-Format-E= poch/Makefile > >> > =A01.12 =A0 =A0 =A0+3 -3 =A0 =A0 =A0ports/devel/p5-DateTime-Format-E= poch/distinfo > >> > > >> > >> Hello. I have a suggestion. Since author switched to Module::Build but > >> =A0for compatibility still using MM format, let's us switch to > >> Module::Build too and a little polishing. > >> Here you can find a patch for it. > >> http://sunner.semmy.ru/~az/p5-DateTime-Format-Epoch.diff > >> And if it's not hard for you please include Chagelog link into commit > >> messages in future. E.g Changes: > >> http://search.cpan.org/dist/AnyEvent-Twitter-Stream/Changes > > > > > > Hello, > > > > You mean add Changelog like you do ? > > > > http://www.freebsd.org/cgi/cvsweb.cgi/ports/textproc/p5-FormValidator-L= ite/Makefile >=20 > I am glad that you're so attentive. But I'm not asking to add your > text in the commit message if it came via GNATS as in my case. But > when you upgrade port by yourself that would be wonderful for p5-. > If you have any comments about my commits I'd be happy to hear them > and learn to do something better. > Am I right that my comments seem harsh, unfair? I suggest some sort of no= nsense? I kindly suggest adding Changelog in all p5- commits. It's a quick way to know what's new on a p5- ports. No, your comments are not harsh at all, some of them are really useful (like your patch for this commit) but you grumble a little bit to much. IMHO, it's better to stop this useless thread. We heard your suggestion and we will add your patch. Best regards, --=20 Philippe Aud=E9oud "Multiple exclamation marks are a sure sign of a diseased mind."