Date: Thu, 7 Sep 2017 12:16:34 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Christian Weisgerber <naddy@mips.inka.de> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r449357 - in head/net-p2p/mktorrent: . files Message-ID: <20170907121634.GA36955@FreeBSD.org> In-Reply-To: <20170907120434.GA25166@lorvorc.mips.inka.de> References: <201709061910.v86JA8Rd002544@repo.freebsd.org> <20170907093407.GA7480@FreeBSD.org> <20170907120434.GA25166@lorvorc.mips.inka.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Sep 07, 2017 at 02:04:34PM +0200, Christian Weisgerber wrote: > Alexey Dokuchaev: > > > ... > > > -MASTER_SITES= SF > > > +MASTER_SITES= https://github.com/Rudde/mktorrent/archive/ > > > +DISTNAME= v${PORTVERSION} > > > +DIST_SUBDIR= ${PORTNAME} > > > > Why not use USE_GITHUB and avoid having to set MASTER_SITES and all these > > DIST_SUBDIR dances? > > I don't know which scheme is preferable. The Porter's Handbook > section on USE_GITHUB starts with "If the distribution file comes > from a specific commit or tag on GitHub for which there is no > officially released file, [...]". But here we have an officially > released if awkwardly named distfile. It was fixed by mat@ (I guess he got tired of trying to teach people and just silently cleans up after them now). I suggest you follow other people commits in addition to reading the PHB, it'll give you ideas and examples of the most common/current practices. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170907121634.GA36955>