From owner-freebsd-fs@FreeBSD.ORG Tue Apr 17 16:32:47 2012 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9AE77106564A; Tue, 17 Apr 2012 16:32:47 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id 71A8B8FC12; Tue, 17 Apr 2012 16:32:47 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id DC217B94D; Tue, 17 Apr 2012 12:32:46 -0400 (EDT) From: John Baldwin To: freebsd-fs@freebsd.org Date: Tue, 17 Apr 2012 11:12:17 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p13; KDE/4.5.5; amd64; ; ) References: <20120415110807.GA75306@freebsd.org> In-Reply-To: <20120415110807.GA75306@freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201204171112.17613.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Tue, 17 Apr 2012 12:32:47 -0400 (EDT) Cc: Alexander Best Subject: Re: fixing a hackish comment in ata-raid.c X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Apr 2012 16:32:47 -0000 On Sunday, April 15, 2012 7:08:08 am Alexander Best wrote: > hi there, > > clang complains about this rather ugly way of putting a comment into normal > code: > > if ((vdcr == NULL) /* && (sa == NULL) * Spares not supported yet */) { > > could somebody please commit the following (or a similar) patch? I think this is probably not worth fixing since ata-raid is due to be replaced by graid. -- John Baldwin