From owner-svn-src-all@FreeBSD.ORG  Fri Dec 19 15:47:50 2008
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 786D41065674;
	Fri, 19 Dec 2008 15:47:50 +0000 (UTC) (envelope-from ed@hoeg.nl)
Received: from palm.hoeg.nl (mx0.hoeg.nl [IPv6:2001:7b8:613:100::211])
	by mx1.freebsd.org (Postfix) with ESMTP id 17B238FC1D;
	Fri, 19 Dec 2008 15:47:49 +0000 (UTC) (envelope-from ed@hoeg.nl)
Received: by palm.hoeg.nl (Postfix, from userid 1000)
	id A41A81CC28; Fri, 19 Dec 2008 16:47:48 +0100 (CET)
Date: Fri, 19 Dec 2008 16:47:48 +0100
From: Ed Schouten <ed@80386.nl>
To: Ivan Voras <ivoras@FreeBSD.org>
Message-ID: <20081219154748.GC1176@hoeg.nl>
References: <200812191449.mBJEnFOb074699@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="qN286NIOm1dtEdh0"
Content-Disposition: inline
In-Reply-To: <200812191449.mBJEnFOb074699@svn.freebsd.org>
User-Agent: Mutt/1.5.18 (2008-05-17)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r186322 - head/sys/kern
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 19 Dec 2008 15:47:50 -0000


--qN286NIOm1dtEdh0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Ivan,

* Ivan Voras <ivoras@FreeBSD.org> wrote:
>   Reviewed by:	ed (older version)

As you mentioned, I didn't review this version. Like I said, I don't
have strong opinions on the subject, but:

> Modified: head/sys/kern/tty.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/sys/kern/tty.c	Fri Dec 19 14:47:38 2008	(r186321)
> +++ head/sys/kern/tty.c	Fri Dec 19 14:49:14 2008	(r186322)
> @@ -871,9 +871,9 @@ tty_alloc(struct ttydevsw *tsw, void *sc
> =20
>  	tty_init_termios(tp);
> =20
> -	cv_init(&tp->t_inwait, "ttyinput");
> -	cv_init(&tp->t_outwait, "ttyoutput");
> -	cv_init(&tp->t_bgwait, "ttybackground");
> +	cv_init(&tp->t_inwait, "ttyinp");
> +	cv_init(&tp->t_outwait, "ttyout");
> +	cv_init(&tp->t_bgwait, "ttybgw");
>  	cv_init(&tp->t_dcdwait, "ttydcd");

If we're renaming them to <=3D6-character strings, maybe it's better to
use "ttyin" and "ttybg"? The old TTY code used these strings as well.

I've also got a small preference of "ttymtx" over "ttylck". "ttymtx"
makes it more clear it is blocked on the mutex, while "lck" could be
literally any form of locking (file locking?).

--=20
 Ed Schouten <ed@80386.nl>
 WWW: http://80386.nl/

--qN286NIOm1dtEdh0
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (FreeBSD)

iEYEARECAAYFAklLwiQACgkQ52SDGA2eCwVwJQCeMLrpFA7R1l4BUP50ALjcE8na
jpcAn2jX4g3gnWpiZQ9n4AGHyWl6cgPh
=6IDB
-----END PGP SIGNATURE-----

--qN286NIOm1dtEdh0--