From owner-svn-src-head@FreeBSD.ORG  Sun Apr 11 22:50:27 2010
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9F0881065672;
	Sun, 11 Apr 2010 22:50:27 +0000 (UTC) (envelope-from sam@errno.com)
Received: from ebb.errno.com (ebb.errno.com [69.12.149.25])
	by mx1.freebsd.org (Postfix) with ESMTP id 700168FC24;
	Sun, 11 Apr 2010 22:50:27 +0000 (UTC)
Received: from ice.local ([10.0.0.115]) (authenticated bits=0)
	by ebb.errno.com (8.13.6/8.12.6) with ESMTP id o3BMoQVi063718
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Sun, 11 Apr 2010 15:50:27 -0700 (PDT) (envelope-from sam@errno.com)
Message-ID: <4BC25232.9070601@errno.com>
Date: Sun, 11 Apr 2010 15:50:26 -0700
From: Sam Leffler <sam@errno.com>
User-Agent: Thunderbird 2.0.0.24 (Macintosh/20100228)
MIME-Version: 1.0
To: Jack F Vogel <jfv@FreeBSD.org>
References: <201004091842.o39IgFbb031014@svn.freebsd.org>
In-Reply-To: <201004091842.o39IgFbb031014@svn.freebsd.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-DCC-CTc-dcc2-Metrics: ebb.errno.com; whitelist
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org
Subject: Re: svn commit: r206429 - head/sys/dev/e1000
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 11 Apr 2010 22:50:27 -0000

Jack F Vogel wrote:
> Author: jfv
> Date: Fri Apr  9 18:42:15 2010
> New Revision: 206429
> URL: http://svn.freebsd.org/changeset/base/206429
> 
> Log:
>   Incorporate suggested improvements from yongari.
>   
>   Also, from feedback, make the multiqueue code an
>   option (EM_MULTIQUEUE) that is off by default.
>   Problems have been seen with UDP when its on.

It is usually a good idea to say what the "suggested improvements" are 
as it's unlikely anyone looking at the commit will have the needed 
context (I certainly did not).

It also seems that you roll-up unrelated changes in one commit; this is 
not advisable.

	Sam