Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 1 Oct 2012 13:23:15 +0200
From:      Michael Gmelin <freebsd@grem.de>
To:        freebsd-ports@freebsd.org
Subject:   Re: Problems submitting patch containing UTF-8 characters
Message-ID:  <20121001132315.23f90c8b@bsd64.grem.de>
In-Reply-To: <25078838-7464-440D-8977-DC2671AE03F3@grem.de>
References:  <20120930050803.7914caf6@bsd64.grem.de> <20120930141935.GA88537@charon.picobyte.net> <25078838-7464-440D-8977-DC2671AE03F3@grem.de>

next in thread | previous in thread | raw e-mail | index | archive | help


On Sun, 30 Sep 2012 16:33:15 +0200
Michael Gmelin <freebsd@grem.de> wrote:

> 
> 
> On 30 Sep 2012, at 16:19, Shaun Amott <shaun@FreeBSD.org> wrote:
> 
> > On Sun, Sep 30, 2012 at 05:08:03AM +0200, Michael Gmelin wrote:
> >> I recently ran into a problem submitting a PR containing UTF-8
> >> characters, they ended up garbled, so the maintainer couldn't
> >> apply the patch cleanly.
> > 
> > GNATS, unfortunately, records no information about character
> > encoding. To make matters worse, it actually removes many headers
> > from e-mail replies, meaning query-pr.cgi can usually only work on
> > guesses and assumptions.
> > 
> > Headers are however preserved inside MIME parts, and if there are
> > any of these headers, they are used; but in this case your MUA
> > hasn't included encoding information here.
> > 
> > Shaun
> > 
> > -- 
> > Shaun Amott // PGP: 0x6B387A9A
> > "A foolish consistency is the hobgoblin
> > of little minds." - Ralph Waldo Emerson
> 
> ...
>

I tries setting the character encoding of the attachment, which fixes
the problem only for viewing the patch on the PR website (so one could
copy and paste the patch). The download links will still deliver
a corrupted patch though, so basically it is impossible to submit a
patch containing UTF-8 characters that can be downloaded from the PR
website correctly*.

I created a bug describing/demonstrating the issue, maybe a member of
portmgr or www could check this.

http://www.freebsd.org/cgi/query-pr.cgi?pr=172195

Michael

* unless one encodes it into a special ASCII format
like base64 and attaches this as text/plain us ascii and of course
tells people how to use it - this is neither practical nor desirable
since it makes it impossible to discuss a patch by just looking at it
on the website.

-- 
Michael Gmelin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121001132315.23f90c8b>