From owner-freebsd-ports@FreeBSD.ORG Mon Oct 1 11:23:24 2012 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0049C106567B for ; Mon, 1 Oct 2012 11:23:23 +0000 (UTC) (envelope-from freebsd@grem.de) Received: from mail.grem.de (outcast.grem.de [213.239.217.27]) by mx1.freebsd.org (Postfix) with SMTP id 54F748FC28 for ; Mon, 1 Oct 2012 11:23:22 +0000 (UTC) Received: (qmail 96782 invoked by uid 89); 1 Oct 2012 11:23:16 -0000 Received: from unknown (HELO bsd64.grem.de) (mg@grem.de@79.251.21.134) by mail.grem.de with ESMTPA; 1 Oct 2012 11:23:16 -0000 Date: Mon, 1 Oct 2012 13:23:15 +0200 From: Michael Gmelin To: freebsd-ports@freebsd.org Message-ID: <20121001132315.23f90c8b@bsd64.grem.de> In-Reply-To: <25078838-7464-440D-8977-DC2671AE03F3@grem.de> References: <20120930050803.7914caf6@bsd64.grem.de> <20120930141935.GA88537@charon.picobyte.net> <25078838-7464-440D-8977-DC2671AE03F3@grem.de> X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.6; amd64-portbld-freebsd9.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: Problems submitting patch containing UTF-8 characters X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Oct 2012 11:23:24 -0000 On Sun, 30 Sep 2012 16:33:15 +0200 Michael Gmelin wrote: > > > On 30 Sep 2012, at 16:19, Shaun Amott wrote: > > > On Sun, Sep 30, 2012 at 05:08:03AM +0200, Michael Gmelin wrote: > >> I recently ran into a problem submitting a PR containing UTF-8 > >> characters, they ended up garbled, so the maintainer couldn't > >> apply the patch cleanly. > > > > GNATS, unfortunately, records no information about character > > encoding. To make matters worse, it actually removes many headers > > from e-mail replies, meaning query-pr.cgi can usually only work on > > guesses and assumptions. > > > > Headers are however preserved inside MIME parts, and if there are > > any of these headers, they are used; but in this case your MUA > > hasn't included encoding information here. > > > > Shaun > > > > -- > > Shaun Amott // PGP: 0x6B387A9A > > "A foolish consistency is the hobgoblin > > of little minds." - Ralph Waldo Emerson > > ... > I tries setting the character encoding of the attachment, which fixes the problem only for viewing the patch on the PR website (so one could copy and paste the patch). The download links will still deliver a corrupted patch though, so basically it is impossible to submit a patch containing UTF-8 characters that can be downloaded from the PR website correctly*. I created a bug describing/demonstrating the issue, maybe a member of portmgr or www could check this. http://www.freebsd.org/cgi/query-pr.cgi?pr=172195 Michael * unless one encodes it into a special ASCII format like base64 and attaches this as text/plain us ascii and of course tells people how to use it - this is neither practical nor desirable since it makes it impossible to discuss a patch by just looking at it on the website. -- Michael Gmelin