From owner-cvs-all Wed Jul 10 18:20:12 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8D07337B400; Wed, 10 Jul 2002 18:20:04 -0700 (PDT) Received: from canning.wemm.org (canning.wemm.org [192.203.228.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3E24B43E64; Wed, 10 Jul 2002 18:20:04 -0700 (PDT) (envelope-from peter@wemm.org) Received: from fw.wemm.org (canning.wemm.org [192.203.228.65]) by canning.wemm.org (Postfix) with ESMTP id 1BAA82A7F2; Wed, 10 Jul 2002 18:20:04 -0700 (PDT) (envelope-from peter@wemm.org) Received: from overcee.wemm.org (overcee.wemm.org [10.0.0.3]) by fw.wemm.org (Postfix) with ESMTP id C1E154C283; Wed, 10 Jul 2002 18:20:03 -0700 (PDT) (envelope-from peter@wemm.org) Received: from wemm.org (localhost [127.0.0.1]) by overcee.wemm.org (Postfix) with ESMTP id 34C23380A; Wed, 10 Jul 2002 18:20:04 -0700 (PDT) (envelope-from peter@wemm.org) X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Matthew Dillon Cc: Dag-Erling Smorgrav , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/bin/chmod chmod.c In-Reply-To: <200207110030.g6B0UdAm076672@apollo.backplane.com> Date: Wed, 10 Jul 2002 18:20:04 -0700 From: Peter Wemm Message-Id: <20020711012004.34C23380A@overcee.wemm.org> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Matthew Dillon wrote: > : > :Matthew Dillon wrote: > : > :> I suppose the minimal fix is to remove __printf0like from err(), > :> errx(), and warn() in /usr/src/include/err.h. So that is what I will > :> do if this problem isn't fixed in the tree by 9:00 p.m. PDT tonight. > : > :No, the correct minimal fix is to stub out the attributes, that's why > :we have fine granularity on them! eg: > > You want to disable the attribute globally? The only problem with it > is with three functions that pass NULL. Well, that's what __printf0__ is for.. Ie: the same as __printf__ but it is supposed to accept a NULL. If it isn't working for those 3 functions, then it wont work elsewhere either. If __printf0__ isn't working, then we should switch it off (since we can). The only real users of this are err/warn/etc and setproctitle() (which also allows a NULL argument). If other code in the tree tries to use __printf0like() itself, it would suffer the same problems, so we would be doing ourselves a favor there too. I'm amused that this only seems to happen on some platforms, while the entire warning is missing from others. Cheers, -Peter -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message