Date: Mon, 2 Feb 2009 21:47:08 +0100 (CET) From: Tobias Rehbein <tobias.rehbein@web.de> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/131308: [PATCH] audio/ripit fails as recent versions of audio/lame print genre list on stderr Message-ID: <200902022047.n12Kl813081212@sushi.pseudo.local> Resent-Message-ID: <200902022050.n12Ko26f038175@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 131308 >Category: ports >Synopsis: [PATCH] audio/ripit fails as recent versions of audio/lame print genre list on stderr >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Mon Feb 02 20:50:02 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Tobias Rehbein >Release: FreeBSD 7.1-RELEASE-p1 i386 >Organization: >Environment: System: FreeBSD sushi.pseudo.local 7.1-RELEASE-p1 FreeBSD 7.1-RELEASE-p1 #33: Tue Jan 13 21:39:05 CET 2009 tobi@sushi.pseudo.local:/usr/obj/usr/src/sys/SUSHI i386 >Description: "lame --genre-list" used to print the genre list on stdout. This has changed recently. The list is now printed on stderr. The ripit script has to be changed accordingly. Note: I reported this problem upstream. >How-To-Repeat: >Fix: --- ripit-3.6-0_1.diff begins here --- diff -ruN audio/ripit.orig/Makefile audio/ripit/Makefile --- audio/ripit.orig/Makefile 2007-07-16 15:56:38.000000000 +0200 +++ audio/ripit/Makefile 2009-02-02 20:27:18.000000000 +0100 @@ -7,6 +7,7 @@ PORTNAME= ripit PORTVERSION= 3.6.0 +PORTREVISION= 1 CATEGORIES= audio MASTER_SITES= http://www.suwald.com/ripit/ diff -ruN audio/ripit.orig/files/patch-ripit.pl audio/ripit/files/patch-ripit.pl --- audio/ripit.orig/files/patch-ripit.pl 1970-01-01 01:00:00.000000000 +0100 +++ audio/ripit/files/patch-ripit.pl 2009-02-02 20:25:12.000000000 +0100 @@ -0,0 +1,42 @@ +--- ./ripit.pl.orig 2009-02-02 19:23:52.000000000 +0000 ++++ ./ripit.pl 2009-02-02 19:24:58.000000000 +0000 +@@ -3398,7 +3398,7 @@ + + # If Lame is not used, don't die if ID3v2-tag is not compliant. + if($lameflag == 0) { +- unless(log_system("lame --genre-list | grep -i \" $genre\$\" > /dev/null ")) { ++ unless(log_system("lame --genre-list 2>&1 | grep -i \" $genre\$\" > /dev/null ")) { + print "Genre $genre is not ID3v2 compliant!\n" + if($verbose >= 1); + print "I continue anyway!\n\n" if($verbose >= 1); +@@ -3417,7 +3417,7 @@ + + # Check if (similar) genre exists. Enter a new one with interaction, + # or take the default one. +- while(!log_system("lame --genre-list | grep -i \"$genre\" > /dev/null ")) { ++ while(!log_system("lame --genre-list 2>&1 | grep -i \"$genre\" > /dev/null ")) { + print "Genre $genre is not ID3v2 compliant!\n" if($verbose >= 1); + if($interaction == 1) { + print "Use \"lame --genre-list\" to get a list!\n"; +@@ -3437,7 +3437,7 @@ + return; + } + elsif($genre =~ /^\d+$/) { +- $genre = `lame --genre-list | grep -i \' $genre \'`; ++ $genre = `lame --genre-list 2>&1 | grep -i \' $genre \'`; + chomp $genre; + } + else { +@@ -3449,10 +3449,10 @@ + # "pop-like" genres! + # There will be a linebreak, if multiple possibilities found. + my $ogenre = $genre; +- $genre = `lame --genre-list | grep -i \'$genre\'`; ++ $genre = `lame --genre-list 2>&1 | grep -i \'$genre\'`; + chomp $genre; + # Second we want THE original genre, if it precisly exists. +- my $testgenre = `lame --genre-list | grep -i \'\^... $ogenre\$\'`; ++ my $testgenre = `lame --genre-list 2>&1 | grep -i \'\^... $ogenre\$\'`; + chomp $testgenre; + $genre = $testgenre if($testgenre); + # If we still have several genres: --- ripit-3.6-0_1.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200902022047.n12Kl813081212>