From owner-p4-projects@FreeBSD.ORG  Sat Jun  2 19:07:13 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 11FD816A47F; Sat,  2 Jun 2007 19:07:13 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id C3E8116A400
	for <perforce@freebsd.org>; Sat,  2 Jun 2007 19:07:12 +0000 (UTC)
	(envelope-from asmrookie@gmail.com)
Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.171])
	by mx1.freebsd.org (Postfix) with ESMTP id 5AEDA13C43E
	for <perforce@freebsd.org>; Sat,  2 Jun 2007 19:07:12 +0000 (UTC)
	(envelope-from asmrookie@gmail.com)
Received: by ug-out-1314.google.com with SMTP id u2so507831uge
	for <perforce@freebsd.org>; Sat, 02 Jun 2007 12:07:11 -0700 (PDT)
DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta;
	h=domainkey-signature:received:received:message-id:date:from:reply-to:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding:sender;
	b=a5Hk+p7xBWc2TeoNNXl/K14A9voE+1F+59m9VPVh+Fq8bvDO+TyY/ag23RcOW+iY4w598nMHgBzyjWrMiob/e2MvehPpJASI1En3+zxjktAthPrEWKqcHrlbDL5W5gwJ9FBkLxewluEHUSAYd/SGg+tFttlJRD+KSYbDfY5k4/o=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta;
	h=received:message-id:date:from:reply-to:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding:sender;
	b=udsVl5KO7eYdYmw1+BVgJRzoKWP1fiDmB81w8fgTrwbQBnlafHYwY0BmN6e8PKakGOwVi8SIUCKDUNjBGwRsTy1LbFetAqQ/HwX2Mz/qvDwJuDYO3U58HILQcj5W7om7BHiuwbpLUU1B2z+ZEkIgpCM807gum/CNn3QyK7Tr++E=
Received: by 10.67.20.3 with SMTP id x3mr1739906ugi.1180811231256;
	Sat, 02 Jun 2007 12:07:11 -0700 (PDT)
Received: from ?151.75.242.86? ( [151.75.242.86])
	by mx.google.com with ESMTP id y37sm1738641iky.2007.06.02.12.07.09;
	Sat, 02 Jun 2007 12:07:10 -0700 (PDT)
Message-ID: <4661BFD0.1080107@FreeBSD.org>
Date: Sat, 02 Jun 2007 21:06:56 +0200
From: Attilio Rao <attilio@FreeBSD.org>
User-Agent: Thunderbird 1.5 (X11/20060526)
MIME-Version: 1.0
To: Rui Paulo <rpaulo@FreeBSD.org>
References: <200706021756.l52Huq9A049371@repoman.freebsd.org>
In-Reply-To: <200706021756.l52Huq9A049371@repoman.freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: Attilio Rao <asmrookie@gmail.com>
Cc: Perforce Change Reviews <perforce@FreeBSD.org>
Subject: Re: PERFORCE change 120788 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: attilio@FreeBSD.org
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 02 Jun 2007 19:07:13 -0000

Rui Paulo wrote:
> http://perforce.freebsd.org/chv.cgi?CH=120788
> 
> Change 120788 by rpaulo@rpaulo_epsilon on 2007/06/02 17:55:58
> 
> 	Add locking.	
> 
> Affected files ...

Ah, but it seems you don't use a "fast" interrupt handler, so you should 
not use a spinlock... spinlocks should only be used in fast interrupt 
handlers, otherwise you bring up all the disvantages of the model...

Attilio