From owner-cvs-src@FreeBSD.ORG Sun Feb 18 13:28:49 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id EBD2416A401; Sun, 18 Feb 2007 13:28:49 +0000 (UTC) (envelope-from brian@Awfulhak.org) Received: from storm.uk.FreeBSD.org (storm.uk.FreeBSD.org [194.242.157.42]) by mx1.freebsd.org (Postfix) with ESMTP id 87E9113C4BC; Sun, 18 Feb 2007 13:28:49 +0000 (UTC) (envelope-from brian@Awfulhak.org) Received: from store.lan.Awfulhak.org (store.lan.Awfulhak.org [172.16.0.35]) by storm.uk.FreeBSD.org (8.13.8/8.13.8) with ESMTP id l1IDSkev095853; Sun, 18 Feb 2007 13:28:47 GMT (envelope-from brian@Awfulhak.org) Received: from store.lan.Awfulhak.org (localhost.localdomain [127.0.0.1]) by localhost (Postfix) with SMTP id E6AC91957C44; Sun, 18 Feb 2007 13:29:03 +0000 (GMT) Received: from gw.Awfulhak.org (gw.lan.Awfulhak.org [172.16.0.1]) by store.lan.Awfulhak.org (Postfix) with ESMTP id A5DFB1957C59; Sun, 18 Feb 2007 13:28:55 +0000 (GMT) Received: from dev.lan.Awfulhak.org (brian@dev.lan.Awfulhak.org [172.16.0.5]) by gw.Awfulhak.org (8.13.8/8.13.8) with ESMTP id l1IDSZLE063004; Sun, 18 Feb 2007 05:28:36 -0800 (PST) (envelope-from brian@Awfulhak.org) Date: Sun, 18 Feb 2007 05:28:33 -0800 From: Brian Somers To: Max Laier Message-ID: <20070218052833.1923d347@dev.lan.Awfulhak.org> In-Reply-To: <200702152102.06506.max@love2party.net> References: <200702151949.l1FJnSnp061671@repoman.freebsd.org> <200702152102.06506.max@love2party.net> X-Mailer: Claws Mail 2.7.2 (GTK+ 2.10.9; i386-portbld-freebsd7.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.4 required=5.0 tests=ALL_TRUSTED autolearn=failed version=3.1.7 X-Spam-Checker-Version: SpamAssassin 3.1.7 (2006-10-05) on gw.lan.Awfulhak.org Cc: cvs-src@FreeBSD.org, Luigi Rizzo , src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/digi digi.c src/sys/kern kern_linker.c subr_firmware.c src/sys/sys linker.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Feb 2007 13:28:50 -0000 On Thu, 15 Feb 2007 21:01:57 +0100 Max Laier wrote: > On Thursday 15 February 2007 20:49, Luigi Rizzo wrote: > > luigi 2007-02-15 19:49:27 UTC > > > > FreeBSD src repository > > > > Modified files: (Branch: RELENG_6) > > sys/dev/digi digi.c > > sys/kern kern_linker.c subr_firmware.c > > sys/sys linker.h > > Log: > > MFC kern_linker.c 1.133 and related changes: > > > > - push Giant into linker_reference_module(); > > - introduce linker_release_module(), which also takes care of > > proper locking. > > > > The latter also fixes a missing mtx_loc/unlock in subr_firmware.c . > > > > Apparently, digi.c is the only external client of > > linker_reference_module() which is a bit suspicious - perhaps dev/digi/ > > could make with a bit of review from someone knowledgeable to check how > > the function is used, and whether it could be replaced by something > > else. > > I have a version of digi(4) in perforce that uses firmware(9). I couldn't > find testers, but with a bit of review this should be committable > nonetheless. > > http://perforce.freebsd.org/depotTreeBrowser.cgi?FSPC=//depot/user/mlaier/firmware/sys/dev/digi/&HIDEDEL=NO > > > Revision Changes Path > > 1.58.2.3 +3 -3 src/sys/dev/digi/digi.c > > 1.117.2.2 +31 -1 src/sys/kern/kern_linker.c > > 1.1.2.4 +1 -3 src/sys/kern/subr_firmware.c > > 1.39.2.2 +8 -0 src/sys/sys/linker.h > > -- > /"\ Best regards, | mlaier@freebsd.org > \ / Max Laier | ICQ #67774661 > X http://pf4freebsd.love2party.net/ | mlaier@EFnet > / \ ASCII Ribbon Campaign | Against HTML Mail and News I could probably do some testing here - I have some digi cards (although only one PCI one AFAIR!!). I originally added linker_reference_module() because I wanted to be able to dynamically load a module from another module, or take a reference to it if it's already there. This was a good way to load/unload the different firmware types after figuring out what the card type is. If firmware(9) avoids this necessity, I'm all for doing away with linker_reference_module(). -- Brian Somers Don't _EVER_ lose your sense of humour !